Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH v4 0/2] [gdb/exp] Fix ignoring of incorrect namespace prefix
Date: Wed, 15 Apr 2026 12:07:36 +0200	[thread overview]
Message-ID: <20260415100738.1297583-1-tdevries@suse.de> (raw)

Hafiz Abid Qadeer reported a problem with namespace handling using a Fortran
program [1].  I wrote an equivalent program in C++, and reproduced the
reported problem with both.  While investigating the problem, I ran into
another problem, for which I filed PR34051.

This series contains two patches.

The first patch refactors a complex assignment in
cp_lookup_symbol_via_imports.

The second patch fixes PR34051, in that same assignment.

Tested on aarch64-linux.

A v1 was submitted here [2].

Changes in v2 [3]:
- updated type of directive_match to bool

Changes in v3 [4]:
- fixed top-level "return -1" in test-case
- fixed typo in test-case

Changes in v4:
- don't use 1 to set bool
- added approval tag to first patch
- replaced "block->function () != nullptr" with
  "block->function_block () != nullptr" to handle the case that current block
  is not a function block, but nested in one
- extended test-case to exercise nested block scenario

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34051

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=34034
[2] v1 https://sourceware.org/pipermail/gdb-patches/2026-April/226370.html
[3] v2 https://sourceware.org/pipermail/gdb-patches/2026-April/226375.html
[4] v3 https://sourceware.org/pipermail/gdb-patches/2026-April/226433.html

Tom de Vries (2):
  [gdb] Break up complex assignment in cp_lookup_symbol_via_imports
  [gdb/exp] Fix ignoring of incorrect namespace prefix

 gdb/cp-namespace.c                 | 28 ++++++++---
 gdb/testsuite/gdb.cp/nsusing-2.cc  | 62 ++++++++++++++++++++++++
 gdb/testsuite/gdb.cp/nsusing-2.exp | 75 ++++++++++++++++++++++++++++++
 3 files changed, 158 insertions(+), 7 deletions(-)
 create mode 100644 gdb/testsuite/gdb.cp/nsusing-2.cc
 create mode 100644 gdb/testsuite/gdb.cp/nsusing-2.exp


base-commit: e860660ab60838b786527823d02b298a3dedcf29
-- 
2.51.0


             reply	other threads:[~2026-04-15 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 10:07 Tom de Vries [this message]
2026-04-15 10:07 ` [PATCH v4 1/2] [gdb] Break up complex assignment in cp_lookup_symbol_via_imports Tom de Vries
2026-04-15 10:07 ` [PATCH v4 2/2] [gdb/exp] Fix ignoring of incorrect namespace prefix Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260415100738.1297583-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox