Re: [PATCH 10/18] sim/erc32: fix -Wunused-but-set-global errors

[Simon Marchi <simon.marchi@efficios.com>]

Adding gdb-patches@.

On 10/19/26 3:28 PM, Simon Marchi wrote:
> Building the erc32 simulator with a recent clang fails with:
> 
>     /home/smarchi/src/binutils-gdb/sim/erc32/erc32.c:159:19: error: variable 'mec_icr' set but not used [-Werror,-Wunused-but-set-global]
>     /home/smarchi/src/binutils-gdb/sim/erc32/erc32.c:165:19: error: variable 'posted_irq' set but not used [-Werror,-Wunused-but-set-global]
>     /home/smarchi/src/binutils-gdb/sim/erc32/erc32.c:247:19: error: variable 'uarta_data' set but not used [-Werror,-Wunused-but-set-global]
> 
> mec_icr and posted_irq are only ever set to 0 in mec_reset.  Remove
> them.
> 
> uarta_data and uartb_data are only read when FAST_UART is not defined,
> but the simulator is build with FAST_UART by default.  Mark them
> ATTRIBUTE_UNUSED, like functions uart_rx, uarta_tx and uartb_tx, which
> are in the same situation.
> 
> Change-Id: I56d04a1141f05a9e1a66984a68c390a36ad9b0a1
> ---
>  sim/erc32/erc32.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/sim/erc32/erc32.c b/sim/erc32/erc32.c
> index 4e9b645d1f3a..f3d9b49b9807 100644
> --- a/sim/erc32/erc32.c
> +++ b/sim/erc32/erc32.c
> @@ -156,13 +156,11 @@ static uint32_t   mec_ffar;
>  static uint32_t   mec_ipr;
>  static uint32_t   mec_imr;
>  static uint32_t   mec_isr;
> -static uint32_t   mec_icr;
>  static uint32_t   mec_ifr;
>  static uint32_t   mec_mcr;	/* MEC control register */
>  static uint32_t   mec_memcfg;	/* Memory control register */
>  static uint32_t   mec_wcr;	/* MEC waitstate register */
>  static uint32_t   mec_iocr;	/* MEC IO control register */
> -static uint32_t   posted_irq;
>  static uint32_t   mec_ersr;	/* MEC error and status register */
>  static uint32_t   mec_tcr;	/* MEC test comtrol register */
>  
> @@ -244,7 +242,7 @@ static int      f1open = 0, f2open = 0;
>  
>  static char     uarta_sreg, uarta_hreg, uartb_sreg, uartb_hreg;
>  static uint32_t   uart_stat_reg;
> -static uint32_t   uarta_data, uartb_data;
> +ATTRIBUTE_UNUSED static uint32_t uarta_data, uartb_data;
>  
>  #ifdef ERA
>  int era = 0;
> @@ -504,7 +502,6 @@ mec_reset(void)
>      mec_ipr = 0;
>      mec_imr = 0x7ffe;
>      mec_isr = 0;
> -    mec_icr = 0;
>      mec_ifr = 0;
>      mec_memcfg = 0x10000;
>      mec_wcr = -1;
> @@ -515,7 +512,6 @@ mec_reset(void)
>      decode_wcr();
>      decode_mcr();
>  
> -    posted_irq = 0;
>      wnuma = wnumb = 0;
>      anum = aind = bnum = bind = 0;
>  
> -- 
> 2.56.0
>