Re: [PATCH 09/18] sim/bpf: remove unused bpf_program_section variable

[Simon Marchi <simon.marchi@efficios.com>]

Adding gdb-patches@.

On 10/19/26 3:28 PM, Simon Marchi wrote:
> Building the BPF simulator with a recent clang fails with:
> 
>     /home/smarchi/src/binutils-gdb/sim/bpf/bpf-sim.c:367:14: error: variable 'bpf_program_section' set but not used [-Werror,-Wunused-but-set-global]
> 
> The --bpf-set-program option stores its argument in this variable, but
> nothing ever reads it, the feature was never implemented.  Remove the
> variable.
> 
> Change-Id: I71edbed055a82fb65a2acecbc38477e3ded80d6a
> ---
>  sim/bpf/bpf-sim.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/sim/bpf/bpf-sim.c b/sim/bpf/bpf-sim.c
> index 9cb272a240e5..34f78c91bc30 100644
> --- a/sim/bpf/bpf-sim.c
> +++ b/sim/bpf/bpf-sim.c
> @@ -362,10 +362,6 @@ bpf_pc_set (sim_cpu *cpu, sim_cia pc)
>  
>  static int64_t skb_data_offset;
>  
> -/* String with the name of the section containing the BPF program to
> -   run.  */
> -static char *bpf_program_section = NULL;
> -
>  \f
>  /***** Handle BPF-specific command line options.  *****/
>  
> @@ -416,7 +412,6 @@ bpf_option_handler (SIM_DESC sd, sim_cpu *cpu ATTRIBUTE_UNUSED, int opt,
>      case OPTION_BPF_SET_PROGRAM:
>        /* XXX: check that the section exists and tell the user about a
>           new start_address.  */
> -      bpf_program_section = xstrdup (arg);
>        break;
>  
>      case OPTION_BPF_SKB_DATA_OFFSET:
> -- 
> 2.56.0
>