From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id scqrECZy1mpnPzQAWB0awg (envelope-from ) for ; Mon, 19 Oct 2026 15:40:22 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=VC7AXASt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 391501E050; Mon, 19 Oct 2026 15:40:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A41DF1E04D for ; Mon, 19 Oct 2026 15:40:21 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 37CCD4BA23E3 for ; Mon, 19 Oct 2026 19:40:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 37CCD4BA23E3 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=VC7AXASt Received: from YT3PR01CU008.outbound.protection.outlook.com (mail-canadacentralazlp170100000.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::]) by sourceware.org (Postfix) with ESMTPS id 316B94BA23E9; Mon, 19 Oct 2026 19:36:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 316B94BA23E9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 316B94BA23E9 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103:: ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1792438572; cv=pass; b=l0HR6hboYNnG1Yn3buaeXV91aenyMKdVUkzCYxKECp6xlYbuhC7lHbhIiUY1n6JMLrfH8THxpJXXTveDJZJvwTvCLsWzTHx8hzH9Bvw2jZhIN361w3/FCpHSU+/Q9hJd1TERCr4FD439nC6M//T5LP4xb497TYkmO0gIjUjeHzQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1792438572; c=relaxed/simple; bh=fGe01m9eoGw0awq7EfBtWGGudM09hj3H31QXu9H/1Fo=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=V/Ozm0VU4Hwa0D9tamohQVBAs+LFBtYakbPY5keovDBfP5lk5O0dPJ7tDiR6OUP4BXYJG9M6qufon9wzZw177bKE7rwDDhP65ulTZOoyRM6FTfTVCeg6Zm+FIkYy66izrTTEzu5TE95ZcredFFxG+C+jGx4XG0xiDF3vtj2V8n8= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=VC7AXASt DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 316B94BA23E9 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dci+zQYDv/b2ectagv+9qRp9015IC7m1e29W9HVmVwKodgTMkNURweSHzsT6KPUNu2MZHNhIN4QXBIBHpH09K78041Ppf93srA7cxcktkqeAUqPD4H6ty1DcmQBvssmcNL2ArwC6giPiPndeJPib9c1WSB+2qXT4zOy0wjOuZX7e6j5H/08muvU1UBKZHNzG6yLbu4s8bHneweaCJTwqAfucjkqIgW/EOzRcfugi06l9wLbOWS1LU4j3x2PoLWEg4OU+CsCBlzmnvUiiO2qvGAgVtDsOsV14fe30hM2I3yR9tlZLnKC8OpZrdsnHH34ZFZ84Yd0gKYhD7ybnUCO9sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MUEpdf3AVgW4rwlTxSW17vLJZJYIYGI2UuABURXpDaY=; b=Z9tymOzJHGk3fzRRiSm0K/Jzjb9TqRbZWl01zr+5hTDPXeWDiZUNtz3CugyuO38RKO83BwFwoP7p8ekqqriGgzIEDbwpEh3dbBd5Gw6/Cc4ytGUA/B1fJ7Vga/tlgvITHSxSuI44AxIWxY6/ceo3JRrwB4/RxZbkmy0qktOpYgPDh0W4CG9F0TZ9RdaqnWnz9Rm3UMHyNHWLwEq00f3g+J+hLZZpI15cJ2yQ3cdk7B7TcIVWWSMEToiNeGAgJkQ+V3xVS3Cb9yFx7HBRY85U0cDZ6vZfPBc4LTWwMv0JxzBqetorMOl7si565fv7CzSlW/jDlv7Vi/92k7pSefkU6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MUEpdf3AVgW4rwlTxSW17vLJZJYIYGI2UuABURXpDaY=; b=VC7AXAStNI1TCAb89cthdkLeedULHGoYBT6NaphbL33yhmeQGxf6HQk5nTK9Ws3guUwRw8j2cDJiRthRD0g2TVic29LtqGIz25L6WiEYr1VSA4JG8uNknElDejp6AauAGdWC3SdC6I/ec/AesVRf5gf4kBqYklbO3rmenQqq+wLSllp85ihJwWkIAvFsNSaBQ5PV47gkFQeKVzwuGqbSva1vCSYgvb5T6mO3z1NQM9TjnwHnyhn8OGVSwJ7XDSH24pUI6dAc2t6EIu6/FHecrzvoldxsu7yxXcDjWZxBvovz1+EYlvGwjSJw9ABzvkAXnSDZOCmj3g6ry6exmLxr/g== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT2PR01MB9015.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.19; Mon, 19 Oct 2026 19:36:09 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%7]) with mapi id 15.21.0522.017; Mon, 19 Oct 2026 19:36:08 +0000 Message-ID: <6ec2bf41-7c39-43d5-a63a-87025ae5a5be@efficios.com> Date: Mon, 19 Oct 2026 15:36:07 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/18] sim/erc32: fix -Wunused-but-set-global errors To: binutils@sourceware.org, gdb-patches@sourceware.org References: <20261019193231.1708375-1-simon.marchi@efficios.com> <20261019193231.1708375-11-simon.marchi@efficios.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20261019193231.1708375-11-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQ1P288CA0007.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:9e::12) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT2PR01MB9015:EE_ X-MS-Office365-Filtering-Correlation-Id: a722f789-f84c-4079-06a2-08df2e183970 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|366016|1800799024|376014|4143699003|56012099006|261009223027099003|10067099003|22082099003|18002099003|6133799003; X-Microsoft-Antispam-Message-Info: t8aryP4LhJ/D/sfVFysydnGa12hbtHWTq2FyOYYR8n4Ui7tixooJfaY42GuULx6SzoRsm+hMjD2ZZzjjTWyBUROoFBuk99iIWPi5xeOAU1be/PvOdAjmy8lwNoO8H4GtAHSIvn30/KM6Lv00D/++nUy0JYJoE0Z5jIm3yYzR4m+kEy0LZxw/iB+bWOAHgHmf1Ch4CtDi4vXOY0+sSdiFP1r4XkbyljD2Z8sADzeJz/7TLLg6vE8/+LpFSngG43CRpRcrK7UF3QjVFq1RNJ5/GJt1qB+Nz66QQJnHarsQpcXadGwFpcGzCPG9P+20ZJjwAWfgYeA0ua4g+BU+Zm8LMBvcv7+nFxa+Exr6M9Ubznbq4VH/V+2TKq/Ip66FfvKZwMouoLfRJi27H/62NdVaN4gDU9O/+iMY5shsjrQR4gBCrGwL3fQ+fSG5aL89fp/7zOaJhMLIKHAJs1uuONVNMGG07lBOt41hWNRbe/QR0dRu5nLJSm9GtkF2kJf+wgPU0mCDBcCjMOUC8L36V2uPmPVYM1aSv6fQJ1ZMqsch6neldkYy5YTCbd0QjW2Zbh6LtJQKnfg7dKnuJ0kZJnBF+VNhQLrLmaOYYnBjKs9BejJNZu+0VAX1ByTf5q+mdC7RnNervdD0x53/fOfChFUMQeARway1L2kTtRmH7ehNV2s= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(4143699003)(56012099006)(261009223027099003)(10067099003)(22082099003)(18002099003)(6133799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGxFV0FOdVdsVzF3RHM3VnliRGYyNGVWeGtRcW5PVHV0eWhKaGhBcVNCcjly?= =?utf-8?B?anNtVXJOS1BOWm02djhMTFh2SWEzTTZlZ3pPQlpVSDNVcUVRdFVrSTRxNkdB?= =?utf-8?B?YlZsRGVndFRieEZxeVRHemplQmtWclJWYmF5WGRoVHV6K3U1TG5sdjI5WFJ5?= =?utf-8?B?cHV1T3ltbSsydTlyWG0yeXNwcG11RjZOa250UDQ3aGpLT2lGaEtzTXpIdUhN?= =?utf-8?B?MHRDcHRidHJDV28rcENBaXgxMGJ5RVNHSjVmVDlaeDAxZFg4RkpsOE1xdHNV?= =?utf-8?B?Y0cybXdKWExRWHR5NCtWaWw0emh4SmI3ai9DdGZUR01jaWtwL2lab1NkSE5R?= =?utf-8?B?RGw1bjhNTGZ6YWhKNlIyTUNZMmdDdThqdUtERVZ6eDhkODdIRnRCandhVHJG?= =?utf-8?B?aGlJRnVRbkFXQ1NYTHBZMHdBcW5tSXl3ZlN4YlNhRkFrQ3U0THRmclFsVS81?= =?utf-8?B?bnJuZC9XeDBkZ20wS2QwbHlmZzNRYXVUSjZHUGhzUjl4RjR5bFZ4clYwMWp5?= =?utf-8?B?VEpjWStmV1ZnY3lSYUhBemtCVVkvSDZqb0RSaVFWd3pUWTU5cVQ4Q1pQeXl4?= =?utf-8?B?U2NDRTNaWFNyODRGSytPNXd0K1hNTEphOEZzOFQ1RlBtYWtZaWQvdWxNamp0?= =?utf-8?B?cXlZeHd0Y3NGa1VoS3h2WXlaMUNablBFa0hJZVBkbHBhclc4WkZCSEs4ZXIz?= =?utf-8?B?S3JhdXgwVTArWWpPSjV2Y1hzK0J0SnNWVEVYVVB3S2NQVGZiL3VYVUlVMnpr?= =?utf-8?B?YXAwTkZuSk81SkJhYmEzNDQ0VE5aa2l4MkZ4NndpWlpIQ2dmS3NLTHBodWhL?= =?utf-8?B?WjdjTkdtQVFKemdPWEVGcndadlcvRERaY0xJRGhJaWJnQjBvU3ZWVlkrRWFs?= =?utf-8?B?OE5qZktrcWt5WG9BeTRwSk9GbTloMGRrQ1d1NEdZVlNjK1JJQmVDTTlBb3NQ?= =?utf-8?B?NE1sd0pjSi82WktJY2NtcE9SMFVkSThsQWNBeUk3ek10WWRoZm5BSWRzUWdl?= =?utf-8?B?VXpEc3k3Q1NXN1dTSXdvWU5rcVpZMDBsVmF2bzRNRGs4NzZSbE90M2tPTGND?= =?utf-8?B?eXpBQXk1bmd2WUhJNzhQVWNpSjB4QXpIWGpRZzVvL0tMMTVxMHkxMHRDRHB1?= =?utf-8?B?cGw0dU84cHJmdGlpOEhXR3FpOFB1aXNHTm5TdVc0TGR6ZDMvVmZpNy9seWkw?= =?utf-8?B?a1lseVc0c1JXNG4rcTVUeTNZVVl5TElFN1F6b0hyUG9CRk5zcGNYbHo5Vkdi?= =?utf-8?B?bElTZXlzbHBKZ1RtM1hTQmZLVWhBYjFxWDNEdHBHTlNhcmRBOHhrem1TbVdG?= =?utf-8?B?ZHdBRkdrcWN1MzNzNkpBaXV2bVdadHUxeU5KV2Jad0RHcUFvVCtVeU5WK1Zy?= =?utf-8?B?d0FwUTNabG53U0svTUpwY1U4TFJDWFJUQ28rYVJQbFhZZDBNRGNUZHZsOEZW?= =?utf-8?B?S21sVXZFazBrSlZqakQrQ1RQVy8vVWxEQWxsKzJxV1Zac05NRWQ3dVMxS1I4?= =?utf-8?B?QVJ6dU5vSUplSC9tdWIwOUpxbXZ1SyszWXBSNFhGVFl0anY3YnEvYTk4YzZZ?= =?utf-8?B?RHRnR1dTQ1lZTFI3d0ozT1NTdXZlbmFJWnV3ZWJEWWJqOEhOVmQ4ekRia1lW?= =?utf-8?B?d2U4dTFPbUo0VW5aM0pyRVNQTHA2akNZNEp6Ky9NbkNrejFtV2RUUDVUWGZ4?= =?utf-8?B?L0tXNkFqM29QR0VhVWt2WDhmY3Z5ZzNGZk5oMlgvT1VPQUJGWllZVkhHb3Jw?= =?utf-8?B?aXJLZWVVVE5wc2Y0YlZqaXZlYjM2ZjgwWVkzUnpkdENFUXZJdnEyc2tFbThY?= =?utf-8?B?dzlBS1Vlc3A5MkNidGthWU90OTNIdFpubHVxYjAwdHdJR09weENpZGtxbFFW?= =?utf-8?B?YUpPenRuTzJJbkpFdnNPNHplRmdsZlZrYzNHYjFOMHVndEtUczJ4Z1ZEVHZr?= =?utf-8?B?aGhoZ0dZYnpIbm1KZE9vOWNqUXpReHlVTE5BV2t6VUwwQ2RRMTg1VmhZTGVV?= =?utf-8?B?bXdKQWNCUjV4MEV4UWZpOUx3QU56alhoMnZiWXg1OFo0bkROa0xPRDZHRVFF?= =?utf-8?B?U2pzdEhKWnhTOXdmRXJLTEhSWno5N0laYzZGOW9CNGpjaExXNmNtTktZU084?= =?utf-8?B?K25iMnU0RHZPUjFqQUcweGNORnltbGVlT3QrK3AwV3NuQmpHeFU0UDRiQlo4?= =?utf-8?B?ZXJ6TjdIdFR2bmFLaXBhOHVyVU5na3Q5N0ZaTFhRN3hzckVWaFpYOGowU1VB?= =?utf-8?B?WjdoWmdZNk5LQlhMQmdLblVIcU5lZjNFNGpwZ2VlVGR3cnJsYjIwcmp5N2FJ?= =?utf-8?B?ckZOanZTQ1JIN3FYcGVvVXFaUzh0SlVsZ2FDRkhZWUN3SG5hTXJydz09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: a722f789-f84c-4079-06a2-08df2e183970 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2026 19:36:08.8716 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i09DROcBcWcfOwqweruKvG8GHB+lWxi0zgNi1j+irLqECOWYQW1NpVQKDtPMltdDrrJqORn/zFjH/kUEw28j8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB9015 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Adding gdb-patches@. On 10/19/26 3:28 PM, Simon Marchi wrote: > Building the erc32 simulator with a recent clang fails with: > > /home/smarchi/src/binutils-gdb/sim/erc32/erc32.c:159:19: error: variable 'mec_icr' set but not used [-Werror,-Wunused-but-set-global] > /home/smarchi/src/binutils-gdb/sim/erc32/erc32.c:165:19: error: variable 'posted_irq' set but not used [-Werror,-Wunused-but-set-global] > /home/smarchi/src/binutils-gdb/sim/erc32/erc32.c:247:19: error: variable 'uarta_data' set but not used [-Werror,-Wunused-but-set-global] > > mec_icr and posted_irq are only ever set to 0 in mec_reset. Remove > them. > > uarta_data and uartb_data are only read when FAST_UART is not defined, > but the simulator is build with FAST_UART by default. Mark them > ATTRIBUTE_UNUSED, like functions uart_rx, uarta_tx and uartb_tx, which > are in the same situation. > > Change-Id: I56d04a1141f05a9e1a66984a68c390a36ad9b0a1 > --- > sim/erc32/erc32.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/sim/erc32/erc32.c b/sim/erc32/erc32.c > index 4e9b645d1f3a..f3d9b49b9807 100644 > --- a/sim/erc32/erc32.c > +++ b/sim/erc32/erc32.c > @@ -156,13 +156,11 @@ static uint32_t mec_ffar; > static uint32_t mec_ipr; > static uint32_t mec_imr; > static uint32_t mec_isr; > -static uint32_t mec_icr; > static uint32_t mec_ifr; > static uint32_t mec_mcr; /* MEC control register */ > static uint32_t mec_memcfg; /* Memory control register */ > static uint32_t mec_wcr; /* MEC waitstate register */ > static uint32_t mec_iocr; /* MEC IO control register */ > -static uint32_t posted_irq; > static uint32_t mec_ersr; /* MEC error and status register */ > static uint32_t mec_tcr; /* MEC test comtrol register */ > > @@ -244,7 +242,7 @@ static int f1open = 0, f2open = 0; > > static char uarta_sreg, uarta_hreg, uartb_sreg, uartb_hreg; > static uint32_t uart_stat_reg; > -static uint32_t uarta_data, uartb_data; > +ATTRIBUTE_UNUSED static uint32_t uarta_data, uartb_data; > > #ifdef ERA > int era = 0; > @@ -504,7 +502,6 @@ mec_reset(void) > mec_ipr = 0; > mec_imr = 0x7ffe; > mec_isr = 0; > - mec_icr = 0; > mec_ifr = 0; > mec_memcfg = 0x10000; > mec_wcr = -1; > @@ -515,7 +512,6 @@ mec_reset(void) > decode_wcr(); > decode_mcr(); > > - posted_irq = 0; > wnuma = wnumb = 0; > anum = aind = bnum = bind = 0; > > -- > 2.56.0 >