From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [AArch64] Fix PR gdb/28681
Date: Tue, 4 Jan 2022 16:04:56 -0300 [thread overview]
Message-ID: <6ded9206-daf3-a6e5-59a8-1aa3cb9d27c0@linaro.org> (raw)
In-Reply-To: <eb719aa8-3ae0-0699-4c5f-fe8e9a18962e@polymtl.ca>
cc-ing Alan back, since the mailing list software seems to have removed
it, although I see it on my end.
On 1/4/22 3:56 PM, Simon Marchi wrote:
>> How about "gdb: on aarch64 non-trivial C++ objects are returned in memory"?
>
> Sounds good. Although if I had to be picky, I'd say it's not perfect
> because it just states a fact (as in "the sky is blue"), and doesn't
> describe the code change the patch does. I would go with something like
> "gdb/aarch64: fix return value location of non-trivial C++ objects".
> The commit message would then say that the architecture's ABI describes
> that this kind of object must be returned in memory, but GDB currently
> erroneously returns it in registers, and that the patch fixes that.
Fair enough.
next prev parent reply other threads:[~2022-01-04 19:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 17:22 Luis Machado via Gdb-patches
2022-01-04 18:09 ` Simon Marchi via Gdb-patches
2022-01-04 18:44 ` Luis Machado via Gdb-patches
2022-01-04 18:47 ` Simon Marchi via Gdb-patches
2022-01-04 18:49 ` Luis Machado via Gdb-patches
2022-01-04 18:56 ` Simon Marchi via Gdb-patches
2022-01-04 19:04 ` Luis Machado via Gdb-patches [this message]
2022-01-05 12:54 ` Andrew Burgess via Gdb-patches
2022-01-11 21:17 ` Luis Machado via Gdb-patches
2022-01-11 21:22 ` [PATCH] [AArch64] Properly extract the reference to a return value from x8 Luis Machado via Gdb-patches
2022-01-12 11:14 ` Andrew Burgess via Gdb-patches
2022-01-13 14:19 ` Luis Machado via Gdb-patches
2022-01-13 15:18 ` Andrew Burgess via Gdb-patches
2022-01-13 15:22 ` Luis Machado via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ded9206-daf3-a6e5-59a8-1aa3cb9d27c0@linaro.org \
--to=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox