From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mBecIoOa1GF7LQAAWB0awg (envelope-from ) for ; Tue, 04 Jan 2022 14:05:39 -0500 Received: by simark.ca (Postfix, from userid 112) id 8B1AA1F0DB; Tue, 4 Jan 2022 14:05:39 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 12B691ECEB for ; Tue, 4 Jan 2022 14:05:27 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 81146385841A for ; Tue, 4 Jan 2022 19:05:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81146385841A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641323126; bh=jDP1VeX/a4EQ6cb1Y4UzxxIGy12LoqPNkiShgh2KWrQ=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Q8dnT9KDs/yfGeVZK3tOskt9MceYEIoWRjV2VKVUjHH7MZtZ+mdton/Ud6ccRw42R cYlm4rGHi1uaRuxRUs7LMut2TJX0lrC3czmbV7heU4PdBx6h0U6TksNmxP7/1TFPyh HnulPGtma8jC+pXLoMJhlV6aDp9O8uJHpaB7fcyc= Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by sourceware.org (Postfix) with ESMTPS id 498BE3858C2C for ; Tue, 4 Jan 2022 19:05:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 498BE3858C2C Received: by mail-qt1-x832.google.com with SMTP id p19so35044441qtw.12 for ; Tue, 04 Jan 2022 11:05:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jDP1VeX/a4EQ6cb1Y4UzxxIGy12LoqPNkiShgh2KWrQ=; b=PbgmAtxMUpQf0l5+nPVWVS0q75BBR+rFpYka1v0pbCR7Y8RU6O7TWICdH7FSqSvDgc JAZEUHQC9s4YKDiDuIGxz/WHHrGlylvWXeVSdKG88LOH3AN3E+r7Bxq0sZv8B3xqVb7i fIpaC4UxlQuRtINA6/5g3UXAP4dlrSEKE/oQGZrOo/aWHR6p6uIy6YP3dWLX94J/QzSb b+4sC87GAWin2+RSJJkc1L14Jc8aEQTZFZ0y26uM0PzdUlxX7UB8RZeH8XWUy4WpeBUw ZtDevKfbd3iKy4ngjJttQua0O4s2MQSF+WODeEdzRU7FjIATG7FZ0/EqndrbCZlzdBxo uMew== X-Gm-Message-State: AOAM533YKxGzTe+9phpuGAMZcz04e9JkhkPQ2OCBNYWONxEJavjj7EGb 9woi4we3BQxdCNuqYfsrD49R8g== X-Google-Smtp-Source: ABdhPJwy1zjBhzKRjQs4Pb/8qwmePq4nWa5L74c3B11Z4A1BYoO1y1n/WSJsFuY91O5ung4cdjhxcg== X-Received: by 2002:ac8:5ac4:: with SMTP id d4mr45739162qtd.306.1641323099535; Tue, 04 Jan 2022 11:04:59 -0800 (PST) Received: from ?IPv6:2804:7f0:4841:563b:d924:ff26:cde9:15a7? ([2804:7f0:4841:563b:d924:ff26:cde9:15a7]) by smtp.gmail.com with ESMTPSA id s1sm31438905qtq.47.2022.01.04.11.04.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 11:04:59 -0800 (PST) Subject: Re: [PATCH] [AArch64] Fix PR gdb/28681 To: Simon Marchi , gdb-patches@sourceware.org References: <20220104172254.3665546-1-luis.machado@linaro.org> <35890e99-0fc3-49b3-4eb1-59cdf606c2e1@polymtl.ca> <1e813eab-3b10-6f78-4375-d72feace6e7c@linaro.org> Message-ID: <6ded9206-daf3-a6e5-59a8-1aa3cb9d27c0@linaro.org> Date: Tue, 4 Jan 2022 16:04:56 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" cc-ing Alan back, since the mailing list software seems to have removed it, although I see it on my end. On 1/4/22 3:56 PM, Simon Marchi wrote: >> How about "gdb: on aarch64 non-trivial C++ objects are returned in memory"? > > Sounds good. Although if I had to be picky, I'd say it's not perfect > because it just states a fact (as in "the sky is blue"), and doesn't > describe the code change the patch does. I would go with something like > "gdb/aarch64: fix return value location of non-trivial C++ objects". > The commit message would then say that the architecture's ABI describes > that this kind of object must be returned in memory, but GDB currently > erroneously returns it in registers, and that the patch fixes that. Fair enough.