From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] [AArch64] Fix PR gdb/28681
Date: Tue, 4 Jan 2022 14:22:54 -0300 [thread overview]
Message-ID: <20220104172254.3665546-1-luis.machado@linaro.org> (raw)
This is the same as commit b1718fcdd1d2a5c514f8ee504ba07fb3f42b8608, but
fixing things for AArch64.
With the patch, gdb.cp/non-trivial-retval.exp has full passes on
AArch64-Linux Ubuntu 20.04/18.04.
---
gdb/aarch64-tdep.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 70fb66954a4..802762f303c 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -2323,6 +2323,15 @@ aarch64_extract_return_value (struct type *type, struct regcache *regs,
valbuf += X_REGISTER_SIZE;
}
}
+ else if (!language_pass_by_reference (type).trivially_copyable)
+ {
+ /* If the object is a non-trivial C++ object, the result is passed as a
+ pointer stored in X0. */
+ CORE_ADDR addr;
+
+ regs->cooked_read (AARCH64_X0_REGNUM, &addr);
+ read_memory (addr, valbuf, TYPE_LENGTH (type));
+ }
else
{
/* For a structure or union the behaviour is as if the value had
--
2.25.1
next reply other threads:[~2022-01-04 17:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 17:22 Luis Machado via Gdb-patches [this message]
2022-01-04 18:09 ` Simon Marchi via Gdb-patches
2022-01-04 18:44 ` Luis Machado via Gdb-patches
2022-01-04 18:47 ` Simon Marchi via Gdb-patches
2022-01-04 18:49 ` Luis Machado via Gdb-patches
2022-01-04 18:56 ` Simon Marchi via Gdb-patches
2022-01-04 19:04 ` Luis Machado via Gdb-patches
2022-01-05 12:54 ` Andrew Burgess via Gdb-patches
2022-01-11 21:17 ` Luis Machado via Gdb-patches
2022-01-11 21:22 ` [PATCH] [AArch64] Properly extract the reference to a return value from x8 Luis Machado via Gdb-patches
2022-01-12 11:14 ` Andrew Burgess via Gdb-patches
2022-01-13 14:19 ` Luis Machado via Gdb-patches
2022-01-13 15:18 ` Andrew Burgess via Gdb-patches
2022-01-13 15:22 ` Luis Machado via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220104172254.3665546-1-luis.machado@linaro.org \
--to=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox