Re: PATCH: Add xmlRegisters= to qsupported query

["H.J. Lu" <hjl.tools@gmail.com>]

On Mon, Mar 29, 2010 at 7:31 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Mon, 29 Mar 2010 07:13:28 -0700
>> From: "H.J. Lu" <hjl.tools@gmail.com>
>> Cc: gdb-patches@sourceware.org
>>
>> >> +target description.  If the stub sees @samp{xmlRegisters=} with
>> >> +target specfic strings separated by comma, it can send @value{GDBN}
>> >                                    ^^^^^^^^
>> > "by a comma".  Also, what do you mean by "it can send", why "can"?
>>
>> I will add `a'.
>>
>> > Doesn't it always send the XML description?
>>
>> Before XML was enabled on x86, we sent
>>
>> "@<target>\
>> <architecture>i386</architecture>\
>> <osabi>GNU/Linux</osabi>\
>> </target>"
>>
>> It isn't the "real" XML target description since it doesn't describe anything.
>
> So how about this text instead:
>
>  If the stub sees @samp{xmlRegisters=} with target specific strings
>  separated by a comma, it will send either an XML target description
>  or an XML stub that states only the architecture and the OSABI.

I will make the change.

>> >> +  /* Tell remote stub that we support XML target description.  */
>> >> +  register_remote_support_xml ("x86");
>> >
>> > A possibly dumb question: what effect will this change in i386-tdep.c
>> > have on i386 targets that don't support remote debugging?  How about
>>
>> Did you mean remote.o wasn't linked in? Can that happen?
>
> I don't know.  The question is, will register_remote_support_xml be
> always available fro an i386 target?

Yes, register_remote_support_xml is available since remote.o is always
linked in for any i386 target.



-- 
H.J.