Re: PATCH: Add xmlRegisters= to qsupported query

["H.J. Lu" <hjl.tools@gmail.com>]

On Sun, Mar 28, 2010 at 11:38 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Sun, 28 Mar 2010 16:46:43 -0700
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> 2010-03-28  H.J. Lu  <hongjiu.lu@intel.com>
>>
>>       * gdb.texinfo (General Query Packets): Add xmlRegisters.
>
> I have a few comments to the documentation part:
>
>> +@item xmlRegisters
>> +This feature indicates that @value{GDBN} supports supports the XML
>                                            ^^^^^^^^^^^^^^^^^
> two "supports" in a row.

I will fix it.

>> +target description.  If the stub sees @samp{xmlRegisters=} with
>> +target specfic strings separated by comma, it can send @value{GDBN}
>                                    ^^^^^^^^
> "by a comma".  Also, what do you mean by "it can send", why "can"?

I will add `a'.

> Doesn't it always send the XML description?

Before XML was enabled on x86, we sent

"@<target>\
<architecture>i386</architecture>\
<osabi>GNU/Linux</osabi>\
</target>"

It isn't the "real" XML target description since it doesn't describe anything.

>> @@ -5943,6 +5944,9 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
>>    set_gdbarch_fast_tracepoint_valid_at (gdbarch,
>>                                       i386_fast_tracepoint_valid_at);
>>
>> +  /* Tell remote stub that we support XML target description.  */
>> +  register_remote_support_xml ("x86");
>
> A possibly dumb question: what effect will this change in i386-tdep.c
> have on i386 targets that don't support remote debugging?  How about

Did you mean remote.o wasn't linked in? Can that happen?

> if GDB was built without libexpat?
>

I will add check for HAVE_LIBEXPAT.

Thanks.


-- 
H.J.