From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71541-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19009 invoked by alias); 29 Mar 2010 14:13:35 -0000
Received: (qmail 18995 invoked by uid 22791); 29 Mar 2010 14:13:34 -0000
X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 	tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG40,SARE_SUB_OBFU_Q1
X-Spam-Check-By: sourceware.org
Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Mar 2010 14:13:30 +0000
Received: by vws4 with SMTP id 4so202080vws.0         for <gdb-patches@sourceware.org>; Mon, 29 Mar 2010 07:13:28 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.90.201 with HTTP; Mon, 29 Mar 2010 07:13:28 -0700 (PDT)
In-Reply-To: <834ojz3a4d.fsf@gnu.org>
References: <20100328204807.GA10649@intel.com> 	 <20100328205207.GA11401@intel.com> <20100328234643.GA25607@intel.com> 	 <834ojz3a4d.fsf@gnu.org>
Date: Mon, 29 Mar 2010 14:13:00 -0000
Received: by 10.220.107.158 with SMTP id b30mr2870307vcp.225.1269872008191;  	Mon, 29 Mar 2010 07:13:28 -0700 (PDT)
Message-ID: <6dc9ffc81003290713p1529c074ia65ff23d5e9a50be@mail.gmail.com>
Subject: Re: PATCH: Add xmlRegisters= to qsupported query
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00986.txt.bz2

On Sun, Mar 28, 2010 at 11:38 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Sun, 28 Mar 2010 16:46:43 -0700
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> 2010-03-28 =A0H.J. Lu =A0<hongjiu.lu@intel.com>
>>
>> =A0 =A0 =A0 * gdb.texinfo (General Query Packets): Add xmlRegisters.
>
> I have a few comments to the documentation part:
>
>> +@item xmlRegisters
>> +This feature indicates that @value{GDBN} supports supports the XML
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0^^^^^^^^^^^^^^^^^
> two "supports" in a row.

I will fix it.

>> +target description. =A0If the stub sees @samp{xmlRegisters=3D} with
>> +target specfic strings separated by comma, it can send @value{GDBN}
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0^^=
^^^^^^
> "by a comma". =A0Also, what do you mean by "it can send", why "can"?

I will add `a'.

> Doesn't it always send the XML description?

Before XML was enabled on x86, we sent

"@<target>\
<architecture>i386</architecture>\
<osabi>GNU/Linux</osabi>\
</target>"

It isn't the "real" XML target description since it doesn't describe anythi=
ng.

>> @@ -5943,6 +5944,9 @@ i386_gdbarch_init (struct gdbarch_info info, struc=
t gdbarch_list *arches)
>> =A0 =A0set_gdbarch_fast_tracepoint_valid_at (gdbarch,
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 i386_fast_tracepoint_valid_at);
>>
>> + =A0/* Tell remote stub that we support XML target description. =A0*/
>> + =A0register_remote_support_xml ("x86");
>
> A possibly dumb question: what effect will this change in i386-tdep.c
> have on i386 targets that don't support remote debugging? =A0How about

Did you mean remote.o wasn't linked in? Can that happen?

> if GDB was built without libexpat?
>

I will add check for HAVE_LIBEXPAT.

Thanks.


--=20
H.J.