From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71545-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 636 invoked by alias); 29 Mar 2010 14:47:22 -0000
Received: (qmail 625 invoked by uid 22791); 29 Mar 2010 14:47:22 -0000
X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 	tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG40,SARE_SUB_OBFU_Q1
X-Spam-Check-By: sourceware.org
Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Mar 2010 14:47:17 +0000
Received: by vws4 with SMTP id 4so222065vws.0         for <gdb-patches@sourceware.org>; Mon, 29 Mar 2010 07:47:15 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.90.201 with HTTP; Mon, 29 Mar 2010 07:47:15 -0700 (PDT)
In-Reply-To: <83iq8f19nq.fsf@gnu.org>
References: <20100328204807.GA10649@intel.com> 	 <20100328205207.GA11401@intel.com> <20100328234643.GA25607@intel.com> 	 <834ojz3a4d.fsf@gnu.org> 	 <6dc9ffc81003290713p1529c074ia65ff23d5e9a50be@mail.gmail.com> 	 <83iq8f19nq.fsf@gnu.org>
Date: Mon, 29 Mar 2010 14:47:00 -0000
Received: by 10.220.126.201 with SMTP id d9mr2709661vcs.226.1269874035626;  	Mon, 29 Mar 2010 07:47:15 -0700 (PDT)
Message-ID: <6dc9ffc81003290747s2ac00adck6ef387289ffb01cf@mail.gmail.com>
Subject: Re: PATCH: Add xmlRegisters= to qsupported query
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00990.txt.bz2

On Mon, Mar 29, 2010 at 7:31 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Mon, 29 Mar 2010 07:13:28 -0700
>> From: "H.J. Lu" <hjl.tools@gmail.com>
>> Cc: gdb-patches@sourceware.org
>>
>> >> +target description. =A0If the stub sees @samp{xmlRegisters=3D} with
>> >> +target specfic strings separated by comma, it can send @value{GDBN}
>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0^^^^^^^^
>> > "by a comma". =A0Also, what do you mean by "it can send", why "can"?
>>
>> I will add `a'.
>>
>> > Doesn't it always send the XML description?
>>
>> Before XML was enabled on x86, we sent
>>
>> "@<target>\
>> <architecture>i386</architecture>\
>> <osabi>GNU/Linux</osabi>\
>> </target>"
>>
>> It isn't the "real" XML target description since it doesn't describe any=
thing.
>
> So how about this text instead:
>
> =A0If the stub sees @samp{xmlRegisters=3D} with target specific strings
> =A0separated by a comma, it will send either an XML target description
> =A0or an XML stub that states only the architecture and the OSABI.

I will make the change.

>> >> + =A0/* Tell remote stub that we support XML target description. =A0*/
>> >> + =A0register_remote_support_xml ("x86");
>> >
>> > A possibly dumb question: what effect will this change in i386-tdep.c
>> > have on i386 targets that don't support remote debugging? =A0How about
>>
>> Did you mean remote.o wasn't linked in? Can that happen?
>
> I don't know. =A0The question is, will register_remote_support_xml be
> always available fro an i386 target?

Yes, register_remote_support_xml is available since remote.o is always
linked in for any i386 target.



--=20
H.J.