From: Luis Machado <luis.machado@linaro.org>
To: Simon Marchi <simark@simark.ca>,
Scott Linder <scott@scottlinder.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2] [gdb] Support frames inlined into the outer frame
Date: Mon, 8 Jun 2020 13:10:12 -0300 [thread overview]
Message-ID: <6c9183a3-6db5-036f-57c6-15dbc5de3c2a@linaro.org> (raw)
In-Reply-To: <f8ae8de6-cfba-3ec9-89c1-0e129bd6a9dd@simark.ca>
On 6/8/20 1:01 PM, Simon Marchi wrote:
> On 2020-06-08 8:00 a.m., Luis Machado wrote:
>>
>> I don't see the same, even with the fixup of memcmp. Though gdb.base/break.exp has full passes with the change, the following tests internal error with the patch...
>>
>> gdb.mi/mi-nonstop.exp
>> gdb.threads/clone-thread_db.exp
>> gdb.threads/current-lwp-dead.exp
>> gdb.threads/hand-call-in-threads.exp
>> gdb.threads/linux-dp.exp
>> gdb.threads/local-watch-wrong-thread.exp
>> gdb.threads/queue-signal.exp
>> gdb.threads/schedlock.exp
>> gdb.threads/thread_check.exp
>> gdb.threads/tls.exp
>>
>> #1 0x0000ffffb7fa1088 in start_thread () from /lib/aarch64-linux-gnu/libpthread.so.0
>> ../../../repos/binutils-gdb/gdb/frame.c:551: internal-error: void compute_frame_id(frame_info*): Assertion `frame_id_p (fi->this_id.value)' failed.
>>
>> Scott, could you please send a v3 so I can make sure I tested the right version? I was initially slightly confused with what version Simon was talking about since I had already tested v2.
>
> I don't see these tests failing. Can you please share your test setup? Maybe we'll find
> what's different between us.
I'm running Ubuntu 18.04.4 LTS, kernel 4.12.13 on an aarch64
Cortex-A72-based machine. Compiler is gcc version 7.5.0.
>
> I've attached the patch I am testing. It is just patch v2 with `== 0` added after the
> memcmp call. I am testing on top of commit 7d8b91fda9fed423b91d4d43b19dd068457fe555. I
> am testing on machine gcc117 of the compile farm, which is running Debian 9.12 (stretch).
> The gcc version there is 6.3.0.
That's the change I did as well (otherwise gdb.base/break.exp would
fail). I'm guessing there may be code generation differences that are
triggering those issues.
I can take a look at the failure mode later, to provide some more
information.
next prev parent reply other threads:[~2020-06-08 16:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 20:43 [RFC][PATCH] " scott
2020-03-18 21:17 ` scott
2020-03-18 21:27 ` Simon Marchi
2020-03-18 21:42 ` scott
2020-03-18 21:45 ` Simon Marchi
2020-03-18 22:06 ` Scott Linder
2020-03-18 22:11 ` [PATCH] [gdb] " Scott Linder
2020-03-24 10:22 ` Andrew Burgess
2020-03-30 22:22 ` scott
2020-03-31 19:18 ` [PATCH v2] " Scott Linder
2020-04-03 17:00 ` Andrew Burgess
2020-04-17 20:41 ` Scott Linder
2020-04-03 19:37 ` Luis Machado
2020-04-17 20:51 ` Scott Linder
2020-06-04 16:11 ` Simon Marchi
2020-06-04 19:23 ` Simon Marchi
2020-06-08 12:00 ` Luis Machado
2020-06-08 16:01 ` Simon Marchi
2020-06-08 16:10 ` Luis Machado [this message]
2020-04-02 19:30 ` [PATCH] " Pedro Alves
2020-04-17 20:35 ` Scott Linder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c9183a3-6db5-036f-57c6-15dbc5de3c2a@linaro.org \
--to=luis.machado@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=scott@scottlinder.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox