From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by sourceware.org (Postfix) with ESMTPS id 845DD385DC00 for ; Mon, 8 Jun 2020 16:10:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 845DD385DC00 Received: by mail-qk1-x742.google.com with SMTP id l17so3951140qki.9 for ; Mon, 08 Jun 2020 09:10:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iS2H5V2A5TP0MCL3RobDEEOEgImDljFR6VkqAAau840=; b=DAErnvhh3l91rRuD8uIiNRPHgCUrA/6xuNgs1PhZz7dvzgvqFx64XY9aphZX7GtwJX g58shB3WjHj1JGmJz/9R3W2k6VUVffEYAtPu2Iv2F3PfNf8fMIt1mwNKLHhX7G76IM0t ZNBZjsh7lvgu4wbOYrSBHny38heA2P44OAq2aaM1/S28Fp5GH197E0DLgXmPsnLJseyt CiGYiuksfua11aXptOvRRzh61L/Ada8NV3+3eZCOSn79cXbbSac0NdmHHmqMT19dDvkD YiwxwubTmjqDNuiypTvvpRazVaW03PcS1G7PDIZC2nf2I/RBEuDBkafL76HgoT3GzLOS 197w== X-Gm-Message-State: AOAM532/lLuNPxbvBrGxOuAH5p1qfHjNicIf5kx4wuanIjtTLUS/bRH/ Ekd6vGZFDnOak1Rgp/dLcP1UTlayQkI= X-Google-Smtp-Source: ABdhPJyC13+YMqdF6Yd3Vzo2NUY298gmU3AhoUKZLt2Jjc6MwEdNrBStQpg1uVPv8M8XkKlz62ud5Q== X-Received: by 2002:a37:9f43:: with SMTP id i64mr23443615qke.173.1591632616686; Mon, 08 Jun 2020 09:10:16 -0700 (PDT) Received: from [192.168.0.185] ([191.34.156.93]) by smtp.gmail.com with ESMTPSA id 205sm7237497qkh.94.2020.06.08.09.10.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2020 09:10:15 -0700 (PDT) Subject: Re: [PATCH v2] [gdb] Support frames inlined into the outer frame To: Simon Marchi , Scott Linder , gdb-patches@sourceware.org References: <41baeec4e477b1287e331e58adb9abf4@scottlinder.com> <20200331191856.31222-1-scott@scottlinder.com> <9e2832f3-c3c4-76da-9c40-85b8055bdee5@simark.ca> <6273d9f5-5c42-620b-daff-c332ab148623@simark.ca> From: Luis Machado Message-ID: <6c9183a3-6db5-036f-57c6-15dbc5de3c2a@linaro.org> Date: Mon, 8 Jun 2020 13:10:12 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2020 16:10:18 -0000 On 6/8/20 1:01 PM, Simon Marchi wrote: > On 2020-06-08 8:00 a.m., Luis Machado wrote: >> >> I don't see the same, even with the fixup of memcmp. Though gdb.base/break.exp has full passes with the change, the following tests internal error with the patch... >> >> gdb.mi/mi-nonstop.exp >> gdb.threads/clone-thread_db.exp >> gdb.threads/current-lwp-dead.exp >> gdb.threads/hand-call-in-threads.exp >> gdb.threads/linux-dp.exp >> gdb.threads/local-watch-wrong-thread.exp >> gdb.threads/queue-signal.exp >> gdb.threads/schedlock.exp >> gdb.threads/thread_check.exp >> gdb.threads/tls.exp >> >> #1  0x0000ffffb7fa1088 in start_thread () from /lib/aarch64-linux-gnu/libpthread.so.0 >> ../../../repos/binutils-gdb/gdb/frame.c:551: internal-error: void compute_frame_id(frame_info*): Assertion `frame_id_p (fi->this_id.value)' failed. >> >> Scott, could you please send a v3 so I can make sure I tested the right version? I was initially slightly confused with what version Simon was talking about since I had already tested v2. > > I don't see these tests failing. Can you please share your test setup? Maybe we'll find > what's different between us. I'm running Ubuntu 18.04.4 LTS, kernel 4.12.13 on an aarch64 Cortex-A72-based machine. Compiler is gcc version 7.5.0. > > I've attached the patch I am testing. It is just patch v2 with `== 0` added after the > memcmp call. I am testing on top of commit 7d8b91fda9fed423b91d4d43b19dd068457fe555. I > am testing on machine gcc117 of the compile farm, which is running Debian 9.12 (stretch). > The gcc version there is 6.3.0. That's the change I did as well (otherwise gdb.base/break.exp would fail). I'm guessing there may be code generation differences that are triggering those issues. I can take a look at the failure mode later, to provide some more information.