Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Scott Linder <scott@scottlinder.com>
To: Luis Machado <luis.machado@linaro.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] [gdb] Support frames inlined into the outer frame
Date: Fri, 17 Apr 2020 16:51:43 -0400	[thread overview]
Message-ID: <20200417205142.GD10358@SVL-L10-SLINDER1.amd.com> (raw)
In-Reply-To: <6b20b512-e9d7-79ec-7dd3-513ec3e2003d@linaro.org>

On Fri, Apr 03, 2020 at 04:37:10PM -0300, Luis Machado wrote:
> Hi Scott,
> 
> I was giving this a try on aarch64-linux to see if it fixed an existing
> problem handling inline frames, but it seems to completely break GDB for
> this architecture.
> 
> The testsuite runs into a number of internal errors of this kind:
> 
> gdb/frame.c:1841: internal-error: frame_info*
> get_next_frame_sentinel_okay(frame_info*): Assertion `this_frame !=
> sentinel_frame' failed.
> 
> Even basic tests like gdb.base/break.exp run into this.
> 
> I'd recommend running this through the buildbot/tryserver to catch
> regressions. This is a very delicate area that is known to break things.
> 

Hi Luis,

Thank you for testing this and giving me some more hints :)

It seems like I will have to get commit access before I can request
buildbot access, so I will start going about that and hopefully be able
to address this in the patch soon.

Thanks,
Scott


  reply	other threads:[~2020-04-17 20:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 20:43 [RFC][PATCH] " scott
2020-03-18 21:17 ` scott
2020-03-18 21:27   ` Simon Marchi
2020-03-18 21:42     ` scott
2020-03-18 21:45       ` Simon Marchi
2020-03-18 22:06         ` Scott Linder
2020-03-18 22:11         ` [PATCH] [gdb] " Scott Linder
2020-03-24 10:22           ` Andrew Burgess
2020-03-30 22:22             ` scott
2020-03-31 19:18               ` [PATCH v2] " Scott Linder
2020-04-03 17:00                 ` Andrew Burgess
2020-04-17 20:41                   ` Scott Linder
2020-04-03 19:37                 ` Luis Machado
2020-04-17 20:51                   ` Scott Linder [this message]
2020-06-04 16:11                 ` Simon Marchi
2020-06-04 19:23                   ` Simon Marchi
2020-06-08 12:00                     ` Luis Machado
2020-06-08 16:01                       ` Simon Marchi
2020-06-08 16:10                         ` Luis Machado
2020-04-02 19:30               ` [PATCH] " Pedro Alves
2020-04-17 20:35                 ` Scott Linder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200417205142.GD10358@SVL-L10-SLINDER1.amd.com \
    --to=scott@scottlinder.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox