From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by sourceware.org (Postfix) with ESMTPS id 25870385F011 for ; Fri, 17 Apr 2020 20:51:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 25870385F011 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=scottlinder.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=scott@scottlinder.com X-Originating-IP: 165.204.55.211 Received: from SVL-L10-SLINDER1.amd.com (unknown [165.204.55.211]) (Authenticated sender: scott@scottlinder.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 35CCB40003; Fri, 17 Apr 2020 20:51:46 +0000 (UTC) Date: Fri, 17 Apr 2020 16:51:43 -0400 From: Scott Linder To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] [gdb] Support frames inlined into the outer frame Message-ID: <20200417205142.GD10358@SVL-L10-SLINDER1.amd.com> References: <41baeec4e477b1287e331e58adb9abf4@scottlinder.com> <20200331191856.31222-1-scott@scottlinder.com> <6b20b512-e9d7-79ec-7dd3-513ec3e2003d@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b20b512-e9d7-79ec-7dd3-513ec3e2003d@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2020 20:51:51 -0000 On Fri, Apr 03, 2020 at 04:37:10PM -0300, Luis Machado wrote: > Hi Scott, > > I was giving this a try on aarch64-linux to see if it fixed an existing > problem handling inline frames, but it seems to completely break GDB for > this architecture. > > The testsuite runs into a number of internal errors of this kind: > > gdb/frame.c:1841: internal-error: frame_info* > get_next_frame_sentinel_okay(frame_info*): Assertion `this_frame != > sentinel_frame' failed. > > Even basic tests like gdb.base/break.exp run into this. > > I'd recommend running this through the buildbot/tryserver to catch > regressions. This is a very delicate area that is known to break things. > Hi Luis, Thank you for testing this and giving me some more hints :) It seems like I will have to get commit access before I can request buildbot access, so I will start going about that and hopefully be able to address this in the patch soon. Thanks, Scott