From: "Marc Khouzam" <marc.khouzam@ericsson.com>
To: <gdb-patches@sourceware.org>
Subject: [Patch] Watchpoint condition fix
Date: Thu, 10 Apr 2008 14:21:00 -0000 [thread overview]
Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA04E1BCD0@ecamlmw720.eamcs.ericsson.se> (raw)
Repost to gdb-patches from gdb mailing list post:
http://sourceware.org/ml/gdb/2008-04/msg00078.html
Watchpoint conditions are broken because they
get deleted when a watchpoint gets re-inserted.
When watchpoints get re-inserted, the condition
string should be always reparsed.
Ok?
2008-04-10 Marc Khouzam <marc.khouzam@ericsson.com>
* breakpoint.c (update_watchpoint): Always reparse
condition.
Index: gdb/breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.307
diff -u -r1.307 breakpoint.c
--- gdb/breakpoint.c 14 Mar 2008 18:57:43 -0000 1.307
+++ gdb/breakpoint.c 10 Apr 2008 12:25:32 -0000
@@ -986,7 +986,7 @@
value_free (v);
}
- if (reparse && b->cond_string != NULL)
+ if (b->cond_string != NULL)
{
char *s = b->cond_string;
if (b->loc->cond)
next reply other threads:[~2008-04-10 12:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 14:21 Marc Khouzam [this message]
2008-04-16 22:15 ` Joel Brobecker
2008-04-17 18:48 ` Marc Khouzam
2008-04-17 21:09 ` Joel Brobecker
2008-04-18 10:10 ` Marc Khouzam
2008-04-19 1:39 ` Doug Evans
2008-04-19 1:58 ` Joel Brobecker
2008-04-22 20:36 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D19CA8D71C89C43A057926FE0D4ADAA04E1BCD0@ecamlmw720.eamcs.ericsson.se \
--to=marc.khouzam@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox