From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-55064-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6882 invoked by alias); 10 Apr 2008 12:35:21 -0000
Received: (qmail 6852 invoked by uid 22791); 10 Apr 2008 12:35:21 -0000
X-Spam-Check-By: sourceware.org
Received: from imr1.ericy.com (HELO imr1.ericy.com) (198.24.6.9)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 10 Apr 2008 12:34:53 +0000
Received: from eusrcmw750.eamcs.ericsson.se (eusrcmw750.exu.ericsson.se [138.85.77.50]) 	by imr1.ericy.com (8.13.1/8.13.1) with ESMTP id m3ACYpNs026132 	for <gdb-patches@sourceware.org>; Thu, 10 Apr 2008 07:34:51 -0500
Received: from ecamlmw720.eamcs.ericsson.se ([142.133.1.72]) by eusrcmw750.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.1830); 	 Thu, 10 Apr 2008 07:34:51 -0500
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; 	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: [Patch] Watchpoint condition fix
Date: Thu, 10 Apr 2008 14:21:00 -0000
Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA04E1BCD0@ecamlmw720.eamcs.ericsson.se>
From: "Marc Khouzam" <marc.khouzam@ericsson.com>
To: <gdb-patches@sourceware.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-04/txt/msg00188.txt.bz2

Repost to gdb-patches from gdb mailing list post:
http://sourceware.org/ml/gdb/2008-04/msg00078.html

Watchpoint conditions are broken because they
get deleted when a watchpoint gets re-inserted.
When watchpoints get re-inserted, the condition=20
string should be always reparsed.

Ok?

2008-04-10  Marc Khouzam  <marc.khouzam@ericsson.com>

	* breakpoint.c (update_watchpoint): Always reparse
	condition.

Index: gdb/breakpoint.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.307
diff -u -r1.307 breakpoint.c
--- gdb/breakpoint.c    14 Mar 2008 18:57:43 -0000      1.307
+++ gdb/breakpoint.c    10 Apr 2008 12:25:32 -0000
@@ -986,7 +986,7 @@
            value_free (v);
        }
=20
-      if (reparse && b->cond_string !=3D NULL)
+      if (b->cond_string !=3D NULL)
        {
          char *s =3D b->cond_string;
          if (b->loc->cond)