From: "Marc Khouzam" <marc.khouzam@ericsson.com>
To: "Joel Brobecker" <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [Patch] Watchpoint condition fix
Date: Fri, 18 Apr 2008 10:10:00 -0000 [thread overview]
Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA04E1BCEC@ecamlmw720.eamcs.ericsson.se> (raw)
In-Reply-To: <20080417205708.GA12735@adacore.com>
> Reformat the comment to avoid the '*' at the beginning of each line
> and put the final '*/' at the end of the last line, not on a new line:
Forgot about that. Eclipse does the comments in its own way.
I fixed it.
I committed the following:
2008-04-17 Marc Khouzam <marc.khouzam@ericsson.com>
* breakpoint.c (update_watchpoint): Always reparse
condition.
Index: gdb/breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.309
diff -u -r1.309 breakpoint.c
--- gdb/breakpoint.c 17 Apr 2008 22:43:17 -0000 1.309
+++ gdb/breakpoint.c 18 Apr 2008 00:35:22 -0000
@@ -994,14 +994,13 @@
value_free (v);
}
- if (reparse && b->cond_string != NULL)
+ /* We just regenerated the list of breakpoint locations.
+ The new location does not have its condition field set to anything
+ and therefore, we must always reparse the cond_string, independently
+ of the value of the reparse flag. */
+ if (b->cond_string != NULL)
{
char *s = b->cond_string;
- if (b->loc->cond)
- {
- xfree (b->loc->cond);
- b->loc->cond = NULL;
- }
b->loc->cond = parse_exp_1 (&s, b->exp_valid_block, 0);
}
}
next prev parent reply other threads:[~2008-04-18 0:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 14:21 Marc Khouzam
2008-04-16 22:15 ` Joel Brobecker
2008-04-17 18:48 ` Marc Khouzam
2008-04-17 21:09 ` Joel Brobecker
2008-04-18 10:10 ` Marc Khouzam [this message]
2008-04-19 1:39 ` Doug Evans
2008-04-19 1:58 ` Joel Brobecker
2008-04-22 20:36 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D19CA8D71C89C43A057926FE0D4ADAA04E1BCEC@ecamlmw720.eamcs.ericsson.se \
--to=marc.khouzam@ericsson.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox