From: Pedro Alves <palves@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Compute proper length for dynamic types of TYPE_CODE_TYPEDEF
Date: Thu, 11 Jun 2020 11:46:42 +0100 [thread overview]
Message-ID: <693d17d6-bc32-f9bd-b51f-af69657b0679@redhat.com> (raw)
In-Reply-To: <20200610113554.GA2428@delia>
On 6/10/20 12:35 PM, Tom de Vries wrote:
> Hi,
>
> [ This patch was submitted earlier here (
> https://sourceware.org/legacy-ml/gdb-patches/2017-06/msg00679.html ).
>
> I've:
> - made the patch applicable to current master
> - made the log message narrower
> - added a missing initialization in the test-case:
> vla_struct_typedef_struct_member_object.something = n * 2;
> - renamed things in the test-case as suggested by Pedro's review comments
> ( https://sourceware.org/legacy-ml/gdb-patches/2017-06/msg00696.html ).
> - re-tested on x86_64-linux.
> ]
>
>
> Any comments?
LGTM.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-06-11 10:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 11:35 Tom de Vries
2020-06-11 10:46 ` Pedro Alves [this message]
2020-06-11 12:38 ` Tom de Vries
-- strict thread matches above, loose matches on Subject: below --
2017-06-24 0:59 Keith Seitz
2017-06-26 11:01 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=693d17d6-bc32-f9bd-b51f-af69657b0679@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox