Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Compute proper length for dynamic types of TYPE_CODE_TYPEDEF
Date: Thu, 11 Jun 2020 14:38:44 +0200	[thread overview]
Message-ID: <ad821f5b-5613-941f-8cab-203e53d01cfa@suse.de> (raw)
In-Reply-To: <693d17d6-bc32-f9bd-b51f-af69657b0679@redhat.com>

On 11-06-2020 12:46, Pedro Alves wrote:
> On 6/10/20 12:35 PM, Tom de Vries wrote:
>> Hi,
>>
>> [ This patch was submitted earlier here (
>> https://sourceware.org/legacy-ml/gdb-patches/2017-06/msg00679.html ).
>>
>> I've:
>> - made the patch applicable to current master
>> - made the log message narrower
>> - added a missing initialization in the test-case:
>>     vla_struct_typedef_struct_member_object.something = n * 2;
>> - renamed things in the test-case as suggested by Pedro's review comments
>>   ( https://sourceware.org/legacy-ml/gdb-patches/2017-06/msg00696.html ).
>> - re-tested on x86_64-linux. 
>> ]
>>
>>
>> Any comments?
> 
> LGTM.
> 

Thanks for the review.

I've just realized that Keith submitted a v2 here (
https://sourceware.org/pipermail/gdb-patches/2017-December/145898.html
), so I seem to have duplicated some work.

Anyway, I've copied the comments in the test-case from that version, and
committed.

Thanks,
- Tom


  reply	other threads:[~2020-06-11 12:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 11:35 Tom de Vries
2020-06-11 10:46 ` Pedro Alves
2020-06-11 12:38   ` Tom de Vries [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-06-24  0:59 Keith Seitz
2017-06-26 11:01 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad821f5b-5613-941f-8cab-203e53d01cfa@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox