From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 350C63840C3D for ; Thu, 11 Jun 2020 10:46:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 350C63840C3D Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-76-4jBzkTVPPv-R3LW7WYyzjw-1; Thu, 11 Jun 2020 06:46:45 -0400 X-MC-Unique: 4jBzkTVPPv-R3LW7WYyzjw-1 Received: by mail-wm1-f69.google.com with SMTP id r1so1186990wmh.7 for ; Thu, 11 Jun 2020 03:46:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=chYsBKpp8Ft1nx8sEdTCeHiSThuPVL5YOKa85vWvaHY=; b=AlkLwmcUZgcu3mlbXVcHUN0bcXR1qxk0714cQYpDcIRx8JaCTmfFzrCUk6A1l2UPeN k+2y7Tkgza0a2qphwsUrjNWejx1BYeUJ/WvpMVWp3IEazWuVF75za5i8QCCGOQuztQM3 mBcroXQkxdDStPnYWDOplElQsbZ8UYi3JzQI0HLoVndvXUeMEPCQqdgPuFoOBBLZqBnE F3Yg4o+diUuryHxLOD7+VP9tYjGxI2S4aiLnzB6hz3rQ8rVBxZQs8NZruczEpzojQ6yu aJZ3Zy1GzvlsE8fLxnSwbpYNRnzlOlJeyNR85vDG91qgtANwjCTIL79kUSwiNiW1VHfm QWzQ== X-Gm-Message-State: AOAM5335FFQ8xueWY5bixBvQNlNDHYHgJzNMSLlBNg4VcthGThtbVlRM hAwXQ9AE7BBt3Xz7Ksd7TODutSysTTRJocgIf+IJLZ7BjaxCsKRh3G/IvnXhR3PyhlLZtzGyVQA X34oUhhc1iU4WwwZH2CtvyQ== X-Received: by 2002:adf:dcc3:: with SMTP id x3mr8620816wrm.93.1591872403728; Thu, 11 Jun 2020 03:46:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6CXgqJ+L9jAItETCrxBGDTGwWBHPtKYbELhoUreehsB1at99xazbP1b5nLSNOkJBt5BQmhw== X-Received: by 2002:adf:dcc3:: with SMTP id x3mr8620799wrm.93.1591872403562; Thu, 11 Jun 2020 03:46:43 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id s7sm4330696wrr.60.2020.06.11.03.46.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2020 03:46:42 -0700 (PDT) Subject: Re: [PATCH] Compute proper length for dynamic types of TYPE_CODE_TYPEDEF To: Tom de Vries , gdb-patches@sourceware.org References: <20200610113554.GA2428@delia> From: Pedro Alves Message-ID: <693d17d6-bc32-f9bd-b51f-af69657b0679@redhat.com> Date: Thu, 11 Jun 2020 11:46:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200610113554.GA2428@delia> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2020 10:46:50 -0000 On 6/10/20 12:35 PM, Tom de Vries wrote: > Hi, > > [ This patch was submitted earlier here ( > https://sourceware.org/legacy-ml/gdb-patches/2017-06/msg00679.html ). > > I've: > - made the patch applicable to current master > - made the log message narrower > - added a missing initialization in the test-case: > vla_struct_typedef_struct_member_object.something = n * 2; > - renamed things in the test-case as suggested by Pedro's review comments > ( https://sourceware.org/legacy-ml/gdb-patches/2017-06/msg00696.html ). > - re-tested on x86_64-linux. > ] > > > Any comments? LGTM. Thanks, Pedro Alves