From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Pedro Alves <palves@redhat.com>, Tom Tromey <tom@tromey.com>,
Pedro Alves via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 3/3] Make exec-file-mismatch compare build IDs
Date: Thu, 21 May 2020 16:23:18 +0200 [thread overview]
Message-ID: <68ef5273df5458656d57c8154a09f26a2d43dab9.camel@skynet.be> (raw)
In-Reply-To: <437fb053-a1e0-67de-0f0e-6a14fb95bf90@redhat.com>
On Thu, 2020-05-21 at 15:02 +0100, Pedro Alves wrote:
> It looks to me like GDB is doing the validation too soon. It should figure out
> that the local file changed, and thus reload it (the "re-reading symbols"), and only
> after, should it do validation? After re-reading, the build ids should match again.
> Or do the "has changed, re-reading" thing earlier, but not sure that's practical.
Yes, doing the build-id comparison later should solve that behaviour.
If you want, I can take a look at this, sometime this week-end probably.
Thanks
Philippe
next prev parent reply other threads:[~2020-05-21 14:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 18:04 [PATCH 0/3] " Pedro Alves
2020-05-17 18:04 ` [PATCH 1/3] Default gdb_bfd_open's fd parameter to -1 Pedro Alves
2020-05-17 18:04 ` [PATCH 2/3] Eliminate target_fileio_open_warn_if_slow Pedro Alves
2020-05-17 18:04 ` [PATCH 3/3] Make exec-file-mismatch compare build IDs Pedro Alves
2020-05-17 18:25 ` Eli Zaretskii
2020-05-18 13:52 ` Pedro Alves
2020-05-18 13:55 ` [PATCH v2 " Pedro Alves
2020-05-18 14:21 ` Philippe Waroquiers
2020-05-19 15:43 ` Pedro Alves
2020-05-19 16:04 ` Tom Tromey
2020-05-19 17:44 ` Pedro Alves
2020-05-21 13:32 ` Philippe Waroquiers
2020-05-21 14:02 ` Pedro Alves
2020-05-21 14:23 ` Philippe Waroquiers [this message]
2020-05-21 14:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68ef5273df5458656d57c8154a09f26a2d43dab9.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox