From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec107.isp.belgacom.be (mailsec107.isp.belgacom.be [195.238.20.103]) by sourceware.org (Postfix) with ESMTPS id 7908D3840C31 for ; Thu, 21 May 2020 14:23:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7908D3840C31 IronPort-SDR: ehbxpUn4gu8HpuOqGs0MuewFIegafPITj5nFLr0NYkjGkE7zTrxM4CQXsoBwBdOj+tWoui705W 4qhe4q1q1PZwLYOe5ysVw/y6gWJ26scGqMi0eVzzh88xwW3///LncHLBptjGa56TmbTzeXUa2u 3reXAym/UCWxl338yW59VXRrRxTAj0+k3C2ndmihi1UXVA1nKRwvqo9gfQnpmtAVgIo0qU0iy4 8A3inx1wcmjca9w7DQr6WsDNOqKiqtRVSNNyiz7ycjNTti/AZOqhsqpf2O6eYDcLcKqDplIjM8 h3Q= IronPort-PHdr: =?us-ascii?q?9a23=3Ag571XRx6V40eiMLXCy+O+j09IxM/srCxBDY+r6?= =?us-ascii?q?Qd0uoeI/ad9pjvdHbS+e9qxAeQG9mCtrQd0rOd7PuocFdDyK7JiGoFfp1IWk?= =?us-ascii?q?1NouQttCtkPvS4D1bmJuXhdS0wEZcKflZk+3amLRodQ56mNBXdrXKo8DEdBA?= =?us-ascii?q?j0OxZrKeTpAI7SiNm82/yv95HJbAhEmTqwbalvIBmrsAnducsbjIV/Iast1x?= =?us-ascii?q?XFpWdFdf5Lzm1yP1KTmBj85sa0/JF99ilbpuws+c1dX6jkZqo0VbNXAigoPG?= =?us-ascii?q?Az/83rqALMTRCT6XsGU2UZiQRHDg7Y5xznRJjxsy/6tu1g2CmGOMD9UL45VS?= =?us-ascii?q?i+46ptVRTlkzkMOSIn/27Li8xwlKNbrwynpxxj2I7ffYWZOONjcq/BYd8WQG?= =?us-ascii?q?xMVdtTWSNcGIOxd4gBAfcBM+hGoYfypVUOogewCgajC+3i0SNIi33s0KEmz+?= =?us-ascii?q?gsCwPL0Qo9FNwOqnTUq9D1Ob8IX+C1zanIyTTDb+tO2Tjj9YPHcgouoeuLXb?= =?us-ascii?q?JpbMrRyFcgFxnejl6NroHlJzOV1uUJs2ia9+pgTfygh3Qpqg5ruDivwd4sip?= =?us-ascii?q?TIho0L0FDE7j50wJ02Jdy4Tk50f8KkHIFLuC6ELoZ7RN4pTG50tigg0LIGpY?= =?us-ascii?q?K7czYQyJQh3xPTdeKLfouU7x/sSOqdPTV1iXJqdb+ihxi+7UetxOL8WMSp3l?= =?us-ascii?q?tHqjRInNfSu30D1BHe6caKR/p980qv1juC0wHe5+dZKk43jarWM4AtzqMym5?= =?us-ascii?q?YJrEjOEC77lF/1gaOLbEkp9Oal5uL6abv8vJCcLZV7igTmP6QrncywHPo3Px?= =?us-ascii?q?AVX2ie5eS8zLrj/VDlQLlSjv05jK3ZsJfCKMQeu6G1Gw5V0oA95BajFzqqzs?= =?us-ascii?q?kUkHsdIF5Ydh+KjpLlNlLTLPziA/qyjUygkDJxyPDHOr3hDI/NLn/GkLr5Zb?= =?us-ascii?q?Z9609cyA4yzdBH/5JbFKsNIfzpVU/rs9zYFwI5Mw2qzOb9E9VwzZgeWWGPA6?= =?us-ascii?q?+fLqzSrUWE6fkxLOWUfo8apC79K+Q55/7plXI5gUUSfa233ZQJc3C1Be5mLF?= =?us-ascii?q?uEbnrsmNgBDX0GsRY5TOzvkFeCSyJcZ26uX6Ig4TE2EJ6mDYDGRo22nLyBxi?= =?us-ascii?q?C7HphIaWFGEFyDDXDod4CcUfcWdC2SOtNhkiADVbW5RI8uyAqhuBbiy7V9Mu?= =?us-ascii?q?rb5i0Yuoz41NVu/O3Tkgwy9SZoAMuD3WCCVXt0kX0SSz8xxqB/rh819lDW6a?= =?us-ascii?q?V0mfsQPNhN6ugBBh8zMYDR1MRgBtzyUx6HddCMHhLuftKjSQ0rSdc80pdaf0?= =?us-ascii?q?F4M8m4iRXOzmyhBLpD0/SzCZAu9er122b8PI5jyn+O+6UrykEvXsBPOHbu0q?= =?us-ascii?q?Fz/U3LDpLCk0iCv72taL4X0THE7mrFynCB6hJ2Sgl1BJ3FXHQeflPb5evw/E?= =?us-ascii?q?TbUr6jE69vZhNByMqDMrNHLMLgl1JfWfbuIs/2eGGgnWqsQxyFkODfJLH2cn?= =?us-ascii?q?kQiX2OQHMPlBoeqDPfbVAz?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2DKBQDRjcZe/yFRiNllHQEBAQEJARI?= =?us-ascii?q?BBQUBQIFHgiyBQyEShFCJAYgHm2ULAQEBAQEBAQEBCCwBAgQBAYREAoIOJzg?= =?us-ascii?q?TAgMBAQEDAgUBAQYBAQEBAQEEBAFsBAEBBwqEUSEBAwEBBQoBQ4I7KQGDDQE?= =?us-ascii?q?FIzMzCAMOCgICJgICVwYBhjmyNIEyhVKDXoFAgQ4qjFGBTD+EIT6HYoI+IgS?= =?us-ascii?q?ZM5luB4JWgQEEkgoHhTwdglGbJJBJngSBaSKBVm2DPU8lnwpCZwIGCAEBAwl?= =?us-ascii?q?0CBOJYy2CFgEB?= X-IPAS-Result: =?us-ascii?q?A2DKBQDRjcZe/yFRiNllHQEBAQEJARIBBQUBQIFHgiyBQ?= =?us-ascii?q?yEShFCJAYgHm2ULAQEBAQEBAQEBCCwBAgQBAYREAoIOJzgTAgMBAQEDAgUBA?= =?us-ascii?q?QYBAQEBAQEEBAFsBAEBBwqEUSEBAwEBBQoBQ4I7KQGDDQEFIzMzCAMOCgICJ?= =?us-ascii?q?gICVwYBhjmyNIEyhVKDXoFAgQ4qjFGBTD+EIT6HYoI+IgSZM5luB4JWgQEEk?= =?us-ascii?q?goHhTwdglGbJJBJngSBaSKBVm2DPU8lnwpCZwIGCAEBAwl0CBOJYy2CFgEB?= Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO md) ([217.136.81.33]) by relay.skynet.be with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 May 2020 16:23:19 +0200 Message-ID: <68ef5273df5458656d57c8154a09f26a2d43dab9.camel@skynet.be> Subject: Re: [PATCH v2 3/3] Make exec-file-mismatch compare build IDs From: Philippe Waroquiers To: Pedro Alves , Tom Tromey , Pedro Alves via Gdb-patches Date: Thu, 21 May 2020 16:23:18 +0200 In-Reply-To: <437fb053-a1e0-67de-0f0e-6a14fb95bf90@redhat.com> References: <20200517180450.14925-1-palves@redhat.com> <20200517180450.14925-4-palves@redhat.com> <87tv0b7vy0.fsf@tromey.com> <6d669d00-236a-cede-5c5e-3d65d3ee5a53@redhat.com> <4719db5fbbd5f3b4026bf4b7637ce922d24e8c6b.camel@skynet.be> <437fb053-a1e0-67de-0f0e-6a14fb95bf90@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2020 14:23:21 -0000 On Thu, 2020-05-21 at 15:02 +0100, Pedro Alves wrote: > It looks to me like GDB is doing the validation too soon. It should figure out > that the local file changed, and thus reload it (the "re-reading symbols"), and only > after, should it do validation? After re-reading, the build ids should match again. > Or do the "has changed, re-reading" thing earlier, but not sure that's practical. Yes, doing the build-id comparison later should solve that behaviour. If you want, I can take a look at this, sometime this week-end probably. Thanks Philippe