Re: [PATCH,v2 testsuite] Fix some duplicate test names

[Luis Machado <luis.machado@linaro.org>]

On 5/26/20 2:50 PM, Pedro Alves wrote:
> Hi, spotted a couple more issues:
> 
> On 5/26/20 6:39 PM, Luis Machado wrote:
>>       gdb_test_multiple "$test" "$test" {
>>   	-re "Breakpoint (\[0-9\]*) at .*$where.*$gdb_prompt $" {
>>   	    set bp $expect_out(1,string)
>> -	    pass "$test"
>> +	    pass "$test inserted as number $bp"
> 
> Same issue with FAIL vs PASS messages.  This needs to be:
> 
>   -     gdb_test_multiple "$test" "$test" {
>   +     gdb_test_multiple "$test" "$test inserted as number $bp" {
>    	-re "Breakpoint (\[0-9\]*) at .*$where.*$gdb_prompt $" {
>    	    set bp $expect_out(1,string)
>   -	    pass "$test"
>   +	    pass $gdb_test_name
> 
> 

This one has a small problem. $bp gets calculated after parsing the 
output. We may have to pass a param to proc so we can differentiate 
between calls.

For example, we attempt to add four breakpoints at "main" later in the test.

We may have to add some prefixes to callers of this proc.