From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by sourceware.org (Postfix) with ESMTPS id 13FAD3949F23 for ; Tue, 26 May 2020 18:42:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 13FAD3949F23 Received: by mail-qt1-x829.google.com with SMTP id y1so6328079qtv.12 for ; Tue, 26 May 2020 11:42:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LdNZeQM9/zb4XH44eDUOijJUZtMnr4jMm4pfRieOsvc=; b=eaTR50daookV3/TgYzUwCAh5wI6eCsYAJqNgxkbWokRTeLDum25AXzn6crVyfZxgDc y2jIkx8o87+ZaRVO0nCj8/sIFzQvXf7b/nj0mZIzXvN1vOftFXios8ftKx9grX3e5a0R x1LnZv2C0W9PftXfMcaBarRHp+S6a2mbRk9Z1rtxqQntobnZzuM+ZATkTMb7BENzU7Lp FTmx/0FOA3zGX35Ms5q6uzG6pKPbsoxpXZR8CZa/e6xBt+JrrlSxVqviOdRwcuc/KO1L LRyoEhsCZ9Ai1B4O3+OEkRbqMvGj1KV0hJdbKhQd6RtbzJtqjKjTu6mtm0Uq9TkVpsg8 C1ug== X-Gm-Message-State: AOAM533+coSZYrAKEK8M/UYKznAGidCcoKBR43QQVEBQmk7wcm2QcXL6 vTpKWfYFGqFhz1Pw/2LWtUG1hyaKSL0= X-Google-Smtp-Source: ABdhPJzw4GY9pGoQmxHImmo20T/UpYShClP0HZBkJ73VUwPVdKiovaThyglOZqxpqPKzVqhnZvYvWA== X-Received: by 2002:ac8:6f28:: with SMTP id i8mr176671qtv.163.1590518544098; Tue, 26 May 2020 11:42:24 -0700 (PDT) Received: from [192.168.0.185] ([191.34.87.30]) by smtp.gmail.com with ESMTPSA id w13sm450056qtk.66.2020.05.26.11.42.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2020 11:42:23 -0700 (PDT) Subject: Re: [PATCH,v2 testsuite] Fix some duplicate test names To: Pedro Alves , gdb-patches@sourceware.org References: <20200526141848.22771-1-luis.machado@linaro.org> <20200526173925.30491-1-luis.machado@linaro.org> <1021975e-b67f-5e04-4469-2640c27add81@redhat.com> From: Luis Machado Message-ID: <6821561e-b6a5-1260-d8a5-d45779fd5c15@linaro.org> Date: Tue, 26 May 2020 15:42:19 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1021975e-b67f-5e04-4469-2640c27add81@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2020 18:42:27 -0000 On 5/26/20 2:50 PM, Pedro Alves wrote: > Hi, spotted a couple more issues: > > On 5/26/20 6:39 PM, Luis Machado wrote: >> gdb_test_multiple "$test" "$test" { >> -re "Breakpoint (\[0-9\]*) at .*$where.*$gdb_prompt $" { >> set bp $expect_out(1,string) >> - pass "$test" >> + pass "$test inserted as number $bp" > > Same issue with FAIL vs PASS messages. This needs to be: > > - gdb_test_multiple "$test" "$test" { > + gdb_test_multiple "$test" "$test inserted as number $bp" { > -re "Breakpoint (\[0-9\]*) at .*$where.*$gdb_prompt $" { > set bp $expect_out(1,string) > - pass "$test" > + pass $gdb_test_name > > This one has a small problem. $bp gets calculated after parsing the output. We may have to pass a param to proc so we can differentiate between calls. For example, we attempt to add four breakpoints at "main" later in the test. We may have to add some prefixes to callers of this proc.