Re: [PATCH,v2 testsuite] Fix some duplicate test names

[Pedro Alves <palves@redhat.com>]

On 5/26/20 7:42 PM, Luis Machado wrote:
> On 5/26/20 2:50 PM, Pedro Alves wrote:
>> Hi, spotted a couple more issues:
>>
>> On 5/26/20 6:39 PM, Luis Machado wrote:
>>>       gdb_test_multiple "$test" "$test" {
>>>       -re "Breakpoint (\[0-9\]*) at .*$where.*$gdb_prompt $" {
>>>           set bp $expect_out(1,string)
>>> -        pass "$test"
>>> +        pass "$test inserted as number $bp"
>>
>> Same issue with FAIL vs PASS messages.  This needs to be:
>>
>>   -     gdb_test_multiple "$test" "$test" {
>>   +     gdb_test_multiple "$test" "$test inserted as number $bp" {
>>        -re "Breakpoint (\[0-9\]*) at .*$where.*$gdb_prompt $" {
>>            set bp $expect_out(1,string)
>>   -        pass "$test"
>>   +        pass $gdb_test_name
>>
>>
> 
> This one has a small problem. $bp gets calculated after parsing the output. We may have to pass a param to proc so we can differentiate between calls.
> 

Oh, I didn't even notice that it's the breakpoint number
that you were printing.  That doesn't seem very stable, like
it could be different on different boards.  Seems best to
avoid using that in the test name, regardless.

> For example, we attempt to add four breakpoints at "main" later in the test.
> 
> We may have to add some prefixes to callers of this proc.

Sounds good.

Thanks,
Pedro Alves