From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: Pedro Alves <palves@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: [PATCH, gdb/testsuite] Use %progbits in watch-loc.c
Date: Thu, 01 Mar 2018 19:02:00 -0000 [thread overview]
Message-ID: <65a57999-129f-c29c-4fd7-af198926cb15@foss.arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
Hi,
While using @progbits in .pushsection work on some targets, it does not
work on arm target where this introduces a comment. This patch replaces
its use in gdb.dlang/watch-loc.c by %progbits which should work on all
targets since it is used in target-independent elf/section7.s GAS test.
ChangeLog entry is as follows:
*** gdb/testsuite/ChangeLog ***
2018-03-01 Thomas Preud'homme <thomas.preudhomme@arm.com>
* gdb.dlang/watch-loc.c: Use %progbits instead of @progbits.
Is this ok for master?
Best regards,
Thomas
[-- Attachment #2: fix_progbits_use_watch-loc.patch --]
[-- Type: text/x-patch, Size: 623 bytes --]
diff --git a/gdb/testsuite/gdb.dlang/watch-loc.c b/gdb/testsuite/gdb.dlang/watch-loc.c
index 06fcc8922b43712dd36ce84600203427477ff69d..46810bcd2372ebc69c4c66e46ec9ee5b80f98b1a 100644
--- a/gdb/testsuite/gdb.dlang/watch-loc.c
+++ b/gdb/testsuite/gdb.dlang/watch-loc.c
@@ -38,7 +38,7 @@ main (void)
generated by GCC. (.gdb_index includes a gdb-generated map
instead.) */
asm (
-" .pushsection .debug_aranges,\"\",@progbits \n"
+" .pushsection .debug_aranges,\"\",%progbits \n"
" .4byte .Laranges_end - .Laranges_start \n" // Length of Address Ranges Info
".Laranges_start: \n"
" .2byte 0x2 \n" // DWARF Version
next reply other threads:[~2018-03-01 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 19:02 Thomas Preudhomme [this message]
2018-03-02 11:44 ` Yao Qi
2018-03-02 11:54 ` Thomas Preudhomme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a57999-129f-c29c-4fd7-af198926cb15@foss.arm.com \
--to=thomas.preudhomme@foss.arm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox