From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Pedro Alves <palves@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH, gdb/testsuite] Use %progbits in watch-loc.c
Date: Fri, 02 Mar 2018 11:54:00 -0000 [thread overview]
Message-ID: <50c31b8f-5256-4df1-8eff-6c5b4b1dbf6a@foss.arm.com> (raw)
In-Reply-To: <86606e4s85.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
Done. Committed the following:
*** gdb/testsuite/ChangeLog ***
2018-03-02 Thomas Preud'homme <thomas.preudhomme@arm.com>
* gdb.dlang/watch-loc.c: Use %progbits instead of @progbits.
* gdb.mi/dw2-ref-missing-frame-func.c: Likewise.
Best regards,
Thomas
On 02/03/18 11:44, Yao Qi wrote:
> Thomas Preudhomme <thomas.preudhomme@foss.arm.com> writes:
>
>> 2018-03-01 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>
>> * gdb.dlang/watch-loc.c: Use %progbits instead of @progbits.
>
> Patch is good to me. A nit, can you update
> gdb.mi/dw2-ref-missing-frame-func.c as well? @progbits is used there as well.
>
[-- Attachment #2: fix_progbits_use.patch --]
[-- Type: text/x-patch, Size: 1312 bytes --]
diff --git a/gdb/testsuite/gdb.dlang/watch-loc.c b/gdb/testsuite/gdb.dlang/watch-loc.c
index 06fcc8922b43712dd36ce84600203427477ff69d..46810bcd2372ebc69c4c66e46ec9ee5b80f98b1a 100644
--- a/gdb/testsuite/gdb.dlang/watch-loc.c
+++ b/gdb/testsuite/gdb.dlang/watch-loc.c
@@ -38,7 +38,7 @@ main (void)
generated by GCC. (.gdb_index includes a gdb-generated map
instead.) */
asm (
-" .pushsection .debug_aranges,\"\",@progbits \n"
+" .pushsection .debug_aranges,\"\",%progbits \n"
" .4byte .Laranges_end - .Laranges_start \n" // Length of Address Ranges Info
".Laranges_start: \n"
" .2byte 0x2 \n" // DWARF Version
diff --git a/gdb/testsuite/gdb.mi/dw2-ref-missing-frame-func.c b/gdb/testsuite/gdb.mi/dw2-ref-missing-frame-func.c
index c6edff851e179207a59ae69848b0e67d77666365..c0800e980f5601001de37c8f6260a79415f581ae 100644
--- a/gdb/testsuite/gdb.mi/dw2-ref-missing-frame-func.c
+++ b/gdb/testsuite/gdb.mi/dw2-ref-missing-frame-func.c
@@ -57,7 +57,7 @@ asm ("cu_text_end:");
generated by GCC. (.gdb_index includes a gdb-generated map
instead.) */
asm (
-" .pushsection .debug_aranges,\"\",@progbits \n"
+" .pushsection .debug_aranges,\"\",%progbits \n"
" .4byte .Laranges_end - .Laranges_start \n" // Length of Address Ranges Info
".Laranges_start: \n"
" .2byte 0x2 \n" // DWARF Version
prev parent reply other threads:[~2018-03-02 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 19:02 Thomas Preudhomme
2018-03-02 11:44 ` Yao Qi
2018-03-02 11:54 ` Thomas Preudhomme [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50c31b8f-5256-4df1-8eff-6c5b4b1dbf6a@foss.arm.com \
--to=thomas.preudhomme@foss.arm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox