From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70806 invoked by alias); 2 Mar 2018 11:54:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70797 invoked by uid 89); 2 Mar 2018 11:54:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1955 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Mar 2018 11:54:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2429E1435; Fri, 2 Mar 2018 03:54:41 -0800 (PST) Received: from [10.2.206.52] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 783F83F318; Fri, 2 Mar 2018 03:54:40 -0800 (PST) Subject: Re: [PATCH, gdb/testsuite] Use %progbits in watch-loc.c To: Yao Qi Cc: Pedro Alves , GDB Patches References: <65a57999-129f-c29c-4fd7-af198926cb15@foss.arm.com> <86606e4s85.fsf@gmail.com> From: Thomas Preudhomme Message-ID: <50c31b8f-5256-4df1-8eff-6c5b4b1dbf6a@foss.arm.com> Date: Fri, 02 Mar 2018 11:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <86606e4s85.fsf@gmail.com> Content-Type: multipart/mixed; boundary="------------CCC195685A8ED33E9BDB8A91" X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00052.txt.bz2 This is a multi-part message in MIME format. --------------CCC195685A8ED33E9BDB8A91 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 622 Done. Committed the following: *** gdb/testsuite/ChangeLog *** 2018-03-02 Thomas Preud'homme * gdb.dlang/watch-loc.c: Use %progbits instead of @progbits. * gdb.mi/dw2-ref-missing-frame-func.c: Likewise. Best regards, Thomas On 02/03/18 11:44, Yao Qi wrote: > Thomas Preudhomme writes: > >> 2018-03-01 Thomas Preud'homme >> >> * gdb.dlang/watch-loc.c: Use %progbits instead of @progbits. > > Patch is good to me. A nit, can you update > gdb.mi/dw2-ref-missing-frame-func.c as well? @progbits is used there as well. > --------------CCC195685A8ED33E9BDB8A91 Content-Type: text/x-patch; name="fix_progbits_use.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix_progbits_use.patch" Content-length: 1312 diff --git a/gdb/testsuite/gdb.dlang/watch-loc.c b/gdb/testsuite/gdb.dlang/watch-loc.c index 06fcc8922b43712dd36ce84600203427477ff69d..46810bcd2372ebc69c4c66e46ec9ee5b80f98b1a 100644 --- a/gdb/testsuite/gdb.dlang/watch-loc.c +++ b/gdb/testsuite/gdb.dlang/watch-loc.c @@ -38,7 +38,7 @@ main (void) generated by GCC. (.gdb_index includes a gdb-generated map instead.) */ asm ( -" .pushsection .debug_aranges,\"\",@progbits \n" +" .pushsection .debug_aranges,\"\",%progbits \n" " .4byte .Laranges_end - .Laranges_start \n" // Length of Address Ranges Info ".Laranges_start: \n" " .2byte 0x2 \n" // DWARF Version diff --git a/gdb/testsuite/gdb.mi/dw2-ref-missing-frame-func.c b/gdb/testsuite/gdb.mi/dw2-ref-missing-frame-func.c index c6edff851e179207a59ae69848b0e67d77666365..c0800e980f5601001de37c8f6260a79415f581ae 100644 --- a/gdb/testsuite/gdb.mi/dw2-ref-missing-frame-func.c +++ b/gdb/testsuite/gdb.mi/dw2-ref-missing-frame-func.c @@ -57,7 +57,7 @@ asm ("cu_text_end:"); generated by GCC. (.gdb_index includes a gdb-generated map instead.) */ asm ( -" .pushsection .debug_aranges,\"\",@progbits \n" +" .pushsection .debug_aranges,\"\",%progbits \n" " .4byte .Laranges_end - .Laranges_start \n" // Length of Address Ranges Info ".Laranges_start: \n" " .2byte 0x2 \n" // DWARF Version --------------CCC195685A8ED33E9BDB8A91--