From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22226 invoked by alias); 1 Mar 2018 19:02:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22215 invoked by uid 89); 1 Mar 2018 19:02:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: foss.arm.com Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Mar 2018 19:02:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7DF4C1435; Thu, 1 Mar 2018 11:02:06 -0800 (PST) Received: from [10.2.206.52] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 070343F487; Thu, 1 Mar 2018 11:02:05 -0800 (PST) To: Pedro Alves , GDB Patches From: Thomas Preudhomme Subject: [PATCH, gdb/testsuite] Use %progbits in watch-loc.c Message-ID: <65a57999-129f-c29c-4fd7-af198926cb15@foss.arm.com> Date: Thu, 01 Mar 2018 19:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------1A06776DD4CE4EC97E922E1D" X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00033.txt.bz2 This is a multi-part message in MIME format. --------------1A06776DD4CE4EC97E922E1D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 528 Hi, While using @progbits in .pushsection work on some targets, it does not work on arm target where this introduces a comment. This patch replaces its use in gdb.dlang/watch-loc.c by %progbits which should work on all targets since it is used in target-independent elf/section7.s GAS test. ChangeLog entry is as follows: *** gdb/testsuite/ChangeLog *** 2018-03-01 Thomas Preud'homme * gdb.dlang/watch-loc.c: Use %progbits instead of @progbits. Is this ok for master? Best regards, Thomas --------------1A06776DD4CE4EC97E922E1D Content-Type: text/x-patch; name="fix_progbits_use_watch-loc.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix_progbits_use_watch-loc.patch" Content-length: 623 diff --git a/gdb/testsuite/gdb.dlang/watch-loc.c b/gdb/testsuite/gdb.dlang/watch-loc.c index 06fcc8922b43712dd36ce84600203427477ff69d..46810bcd2372ebc69c4c66e46ec9ee5b80f98b1a 100644 --- a/gdb/testsuite/gdb.dlang/watch-loc.c +++ b/gdb/testsuite/gdb.dlang/watch-loc.c @@ -38,7 +38,7 @@ main (void) generated by GCC. (.gdb_index includes a gdb-generated map instead.) */ asm ( -" .pushsection .debug_aranges,\"\",@progbits \n" +" .pushsection .debug_aranges,\"\",%progbits \n" " .4byte .Laranges_end - .Laranges_start \n" // Length of Address Ranges Info ".Laranges_start: \n" " .2byte 0x2 \n" // DWARF Version --------------1A06776DD4CE4EC97E922E1D--