From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/8] Correctly handle inline functions with dwz
Date: Mon, 26 Jan 2026 16:42:40 -0500 [thread overview]
Message-ID: <64c95b4f-abe8-410b-9514-2fe0a5df5d82@simark.ca> (raw)
In-Reply-To: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com>
On 1/26/26 4:33 PM, Tom Tromey wrote:
> The new indexer does not correctly handle inline functions when 'dwz'
> is used to compress the DWARF. This series fixes the bug, cleaning up
> a number of other things on the way.
>
> I've separately regression tested each patch in this series on x86-64
> Fedora 41. I've also regression tested the series as a whole with the
> dwz, gdb-index, and debug-names boards.
>
> Even with that I messed up somehow, so v1 didn't actually fix the bug
> in question. I must have modified the patches after testing..?
>
> Anyway in v2 I've moved the line recording the CU inclusion and added
> a comment explaining the placement. I re-ran the aformentioned tests
> and didn't touch anything.
>
> Signed-off-by: Tom Tromey <tom@tromey.com>
I will test this series on my CI that runs the testsuite with the
various DWARF boards.
In the mean time, there are some things that pre-commit suggests to fix:
codespell................................................................Failed
- hook id: codespell
- exit code: 65
gdb/dwarf2/cooked-index-worker.c:114: includee ==> include
check-whitespace.........................................................Failed
- hook id: check-whitespace
- exit code: 2
gdb/dwarf2/index-write.c:1314: indent with spaces.
+ {
Simon
next prev parent reply other threads:[~2026-01-26 21:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 21:33 Tom Tromey
2026-01-26 21:33 ` [PATCH v2 1/8] Don't call add_dependence from index_imported_unit Tom Tromey
2026-01-26 21:33 ` [PATCH v2 2/8] Skip partial units in process_psymtab_comp_unit Tom Tromey
2026-01-26 21:33 ` [PATCH v2 3/8] Don't consider DW_TAG_inlined_subroutine as interesting Tom Tromey
2026-01-26 21:33 ` [PATCH v2 4/8] Combine two cases in cooked_index_functions::search Tom Tromey
2026-01-26 21:33 ` [PATCH v2 5/8] Remove C++ special case from process_imported_unit_die Tom Tromey
2026-01-26 21:33 ` [PATCH v2 6/8] Have iterate_over_one_compunit_symtab search included symtabs Tom Tromey
2026-01-30 22:04 ` Simon Marchi
2026-01-31 15:04 ` Tom Tromey
2026-01-26 21:33 ` [PATCH v2 7/8] Handle inline functions with dwz Tom Tromey
2026-02-10 3:51 ` Simon Marchi
2026-01-26 21:33 ` [PATCH v2 8/8] Update .debug_names documentation Tom Tromey
2026-02-10 4:26 ` Simon Marchi
2026-02-10 16:14 ` Tom Tromey
2026-02-10 17:03 ` Simon Marchi
2026-02-10 19:52 ` Tom Tromey
2026-02-10 20:25 ` Simon Marchi
2026-02-10 20:46 ` Tom Tromey
2026-01-26 21:42 ` Simon Marchi [this message]
2026-01-26 23:31 ` [PATCH v2 0/8] Correctly handle inline functions with dwz Tom Tromey
2026-01-26 22:05 ` Tom de Vries
2026-01-30 22:06 ` Simon Marchi
2026-03-05 18:53 ` Tom Tromey
2026-02-06 19:14 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64c95b4f-abe8-410b-9514-2fe0a5df5d82@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox