Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH v2 8/8] Update .debug_names documentation
Date: Tue, 10 Feb 2026 13:46:05 -0700	[thread overview]
Message-ID: <87a4xg1g4y.fsf@tromey.com> (raw)
In-Reply-To: <72ab46ea-9db9-4af7-9dc0-9165f2853013@simark.ca> (Simon Marchi's message of "Tue, 10 Feb 2026 15:25:31 -0500")

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> Since the reader pre-loads all the DIEs I am thinking it probably won't
>> be super expensive to also iterate over them.  Or alternatively we could
>> have the DIE-loading process notice all the spots where an inlined
>> function is seen.

Simon> I was actually wondering if we could avoid pre-loading all the
Simon> DIEs from the start.

This is the approach the cooked indexer takes, so I looked at it for the
full reader.  However the full reader has a few things that make it
harder.

I was mostly looking at this in the context of lazy loading... and there
are even more things that make fully lazy loading hard, like the
"abstract_to_concrete" map and the way that rust_union_quirks currently
works.

Anyway, probably the main issue with lazy DIE loading is that there's
code in the full reader that uses die_info::parent.  This by itself
isn't so bad but it wouldn't work if it's combined with random-access
DIE lookups.

Some of these uses are due to the weird/bad way the full reader computes
names.  Though IIRC there are some uses that are harder to get rid of.

Tom

  reply	other threads:[~2026-02-10 20:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 21:33 [PATCH v2 0/8] Correctly handle inline functions with dwz Tom Tromey
2026-01-26 21:33 ` [PATCH v2 1/8] Don't call add_dependence from index_imported_unit Tom Tromey
2026-01-26 21:33 ` [PATCH v2 2/8] Skip partial units in process_psymtab_comp_unit Tom Tromey
2026-01-26 21:33 ` [PATCH v2 3/8] Don't consider DW_TAG_inlined_subroutine as interesting Tom Tromey
2026-01-26 21:33 ` [PATCH v2 4/8] Combine two cases in cooked_index_functions::search Tom Tromey
2026-01-26 21:33 ` [PATCH v2 5/8] Remove C++ special case from process_imported_unit_die Tom Tromey
2026-01-26 21:33 ` [PATCH v2 6/8] Have iterate_over_one_compunit_symtab search included symtabs Tom Tromey
2026-01-30 22:04   ` Simon Marchi
2026-01-31 15:04     ` Tom Tromey
2026-01-26 21:33 ` [PATCH v2 7/8] Handle inline functions with dwz Tom Tromey
2026-02-10  3:51   ` Simon Marchi
2026-01-26 21:33 ` [PATCH v2 8/8] Update .debug_names documentation Tom Tromey
2026-02-10  4:26   ` Simon Marchi
2026-02-10 16:14     ` Tom Tromey
2026-02-10 17:03       ` Simon Marchi
2026-02-10 19:52         ` Tom Tromey
2026-02-10 20:25           ` Simon Marchi
2026-02-10 20:46             ` Tom Tromey [this message]
2026-01-26 21:42 ` [PATCH v2 0/8] Correctly handle inline functions with dwz Simon Marchi
2026-01-26 23:31   ` Tom Tromey
2026-01-26 22:05 ` Tom de Vries
2026-01-30 22:06 ` Simon Marchi
2026-03-05 18:53   ` Tom Tromey
2026-02-06 19:14 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a4xg1g4y.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox