From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vNb0Duzfd2kDsRYAWB0awg (envelope-from ) for ; Mon, 26 Jan 2026 16:43:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1769463788; bh=BbEpjxyTNBkenXg66OqQf2C9ndyAsx7YWvcCscjNEEE=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=N6Nzmc/02EFxIbCEPO74j4DhkGNaRp6zWiNWDQwtO60FcS0yVS1QryvwibOQlqndf KPCQHRvxC+YIsnY5F0EBcXJM4ZHXvb/n3GuQeHLl0ta/fUxMZfPejVlk8Ct8LV+Lw/ lqnPTUZfsV71RI/0bEOr6Pd6M9Y5RdpFnMqqGLsI= Received: by simark.ca (Postfix, from userid 112) id 284921E0DD; Mon, 26 Jan 2026 16:43:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=WIams40K; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 68FBA1E089 for ; Mon, 26 Jan 2026 16:43:07 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D73184BC8954 for ; Mon, 26 Jan 2026 21:43:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D73184BC8954 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=WIams40K Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9D5354BA2E30 for ; Mon, 26 Jan 2026 21:42:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D5354BA2E30 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9D5354BA2E30 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769463761; cv=none; b=oh6iUqvuy5M6eEGCal+B35XE0w6LZDwoZq479fP+vBOozUA+RcNJl+3ndjsdwR59t5EQw706nKAwTTDzm2wLHl5qme90v682r+lU1zfBHR9gnOzuujdFBKNkfIVWWJRVMrWzlzdj1+B+UkgRkf7IWE538SQgwDreKD21A+69jUk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769463761; c=relaxed/simple; bh=BbEpjxyTNBkenXg66OqQf2C9ndyAsx7YWvcCscjNEEE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=OtSAKtoAr7I9II3tnnc87Wl8iOawHg+bHHKVJYuNYwwRsvBxzBh+g/5OOc2L5icZKVvfiSeynikOaCP0IVjhtquEA6EtmyU51jc2gJ/zQPgz5f/8bFM7DFGBsa31Z2ICT3c/iXf1faY4XxxzhhlfME7SYW8hFofjZUQMb5MH7Vs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D5354BA2E30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1769463761; bh=BbEpjxyTNBkenXg66OqQf2C9ndyAsx7YWvcCscjNEEE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=WIams40KnyMvRrfxlxvWmPSku7c87rssI1yl7ZO0HCfmvYZoBmM6J+UFwguRVBGz2 9yesBL2ciNjuM/zJGaIgzxhJFChmgeITx1t84MR8UGhXdxszd9gq9RjsPjOE22xi3d Kbr410GfAvSq4R4WdwdfCLRclttHNC6FrOohW/mE= Received: by simark.ca (Postfix) id E75231E089; Mon, 26 Jan 2026 16:42:40 -0500 (EST) Message-ID: <64c95b4f-abe8-410b-9514-2fe0a5df5d82@simark.ca> Date: Mon, 26 Jan 2026 16:42:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/8] Correctly handle inline functions with dwz To: Tom Tromey , gdb-patches@sourceware.org References: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/26/26 4:33 PM, Tom Tromey wrote: > The new indexer does not correctly handle inline functions when 'dwz' > is used to compress the DWARF. This series fixes the bug, cleaning up > a number of other things on the way. > > I've separately regression tested each patch in this series on x86-64 > Fedora 41. I've also regression tested the series as a whole with the > dwz, gdb-index, and debug-names boards. > > Even with that I messed up somehow, so v1 didn't actually fix the bug > in question. I must have modified the patches after testing..? > > Anyway in v2 I've moved the line recording the CU inclusion and added > a comment explaining the placement. I re-ran the aformentioned tests > and didn't touch anything. > > Signed-off-by: Tom Tromey I will test this series on my CI that runs the testsuite with the various DWARF boards. In the mean time, there are some things that pre-commit suggests to fix: codespell................................................................Failed - hook id: codespell - exit code: 65 gdb/dwarf2/cooked-index-worker.c:114: includee ==> include check-whitespace.........................................................Failed - hook id: check-whitespace - exit code: 2 gdb/dwarf2/index-write.c:1314: indent with spaces. + { Simon