From: Simon Marchi <simark@simark.ca>
To: Hannes Domani <ssbssa@yahoo.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Fix install-strip for cross-compilation
Date: Tue, 31 Dec 2019 18:50:00 -0000 [thread overview]
Message-ID: <64c719e2-df88-6cd8-3f5b-246f0f7b7d58@simark.ca> (raw)
In-Reply-To: <20191231184222.34267-1-ssbssa@yahoo.de>
On 2019-12-31 1:42 p.m., Hannes Domani via gdb-patches wrote:
> The variable INSTALL_PROGRAM_ENV sets up STRIPPROG for the cross-compiler.
>
> If this is not done, the host 'strip' is used, and fails:
>
> /bin/sh /c/src/repos/binutils-gdb.git/install-sh -c -s gdb.exe \
> /gdb/gdb64-git/bin/$transformed_name.exe
> strip.exe:C:/gdb/gdb64-git/bin/_inst.33599_: file format not recognized
>
> With this change, it's fine:
>
> STRIPPROG='x86_64-w64-mingw32-strip' \
> /bin/sh /c/src/repos/binutils-gdb.git/install-sh -c -s gdb.exe \
> /gdb/gdb64-git/bin/$transformed_name.exe
Thanks for updating the change log, this LGTM. I believe you don't have write access
to the repo, is that right? Would you like me to push the patch on your behalf, or
would you like to get a write access (useful if you plan on sending patches regularly)?
Simon
next prev parent reply other threads:[~2019-12-31 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191231184222.34267-1-ssbssa.ref@yahoo.de>
2019-12-31 18:42 ` Hannes Domani via gdb-patches
2019-12-31 18:50 ` Simon Marchi [this message]
2019-12-31 19:05 ` Hannes Domani via gdb-patches
2019-12-31 20:12 ` Simon Marchi
2020-01-01 21:00 ` Hannes Domani via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64c719e2-df88-6cd8-3f5b-246f0f7b7d58@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox