From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73922 invoked by alias); 31 Dec 2019 18:50:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73910 invoked by uid 89); 31 Dec 2019 18:50:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=regularly, HX-Languages-Length:893 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Dec 2019 18:50:47 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8C3E21E581; Tue, 31 Dec 2019 13:50:45 -0500 (EST) Subject: Re: [PATCH v2] Fix install-strip for cross-compilation To: Hannes Domani , gdb-patches@sourceware.org References: <20191231184222.34267-1-ssbssa.ref@yahoo.de> <20191231184222.34267-1-ssbssa@yahoo.de> From: Simon Marchi Message-ID: <64c719e2-df88-6cd8-3f5b-246f0f7b7d58@simark.ca> Date: Tue, 31 Dec 2019 18:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20191231184222.34267-1-ssbssa@yahoo.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg01090.txt.bz2 On 2019-12-31 1:42 p.m., Hannes Domani via gdb-patches wrote: > The variable INSTALL_PROGRAM_ENV sets up STRIPPROG for the cross-compiler. > > If this is not done, the host 'strip' is used, and fails: > > /bin/sh /c/src/repos/binutils-gdb.git/install-sh -c -s gdb.exe \ > /gdb/gdb64-git/bin/$transformed_name.exe > strip.exe:C:/gdb/gdb64-git/bin/_inst.33599_: file format not recognized > > With this change, it's fine: > > STRIPPROG='x86_64-w64-mingw32-strip' \ > /bin/sh /c/src/repos/binutils-gdb.git/install-sh -c -s gdb.exe \ > /gdb/gdb64-git/bin/$transformed_name.exe Thanks for updating the change log, this LGTM. I believe you don't have write access to the repo, is that right? Would you like me to push the patch on your behalf, or would you like to get a write access (useful if you plan on sending patches regularly)? Simon