Re: [PATCH v2] Fix install-strip for cross-compilation

["Hannes Domani via gdb-patches" <gdb-patches@sourceware.org>]

 Am Dienstag, 31. Dezember 2019, 19:50:47 MEZ hat Simon Marchi <simark@simark.ca> Folgendes geschrieben:

> On 2019-12-31 1:42 p.m., Hannes Domani via gdb-patches wrote:
>
> > The variable INSTALL_PROGRAM_ENV sets up STRIPPROG for the cross-compiler.
> >
> > If this is not done, the host 'strip' is used, and fails:
> >
> > /bin/sh /c/src/repos/binutils-gdb.git/install-sh -c -s gdb.exe \
> >  /gdb/gdb64-git/bin/$transformed_name.exe
> > strip.exe:C:/gdb/gdb64-git/bin/_inst.33599_: file format not recognized
> >
> > With this change, it's fine:
> >
> > STRIPPROG='x86_64-w64-mingw32-strip' \
> >  /bin/sh /c/src/repos/binutils-gdb.git/install-sh -c -s gdb.exe \
> >  /gdb/gdb64-git/bin/$transformed_name.exe
>
>
> Thanks for updating the change log, this LGTM.  I believe you don't have write access
> to the repo, is that right?  Would you like me to push the patch on your behalf, or
> would you like to get a write access (useful if you plan on sending patches regularly)?

Yes, I don't have write access, and I do plan to send more patches in the future.

With write access, is there more to it than just push the patch?


Regards
Hannes Domani