From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103698 invoked by alias); 31 Dec 2019 19:05:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103690 invoked by uid 89); 31 Dec 2019 19:05:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*x:20100101, H*x:Firefox, H*x:71.0, H*UA:71.0 X-HELO: sonic307-54.consmr.mail.ir2.yahoo.com Received: from sonic307-54.consmr.mail.ir2.yahoo.com (HELO sonic307-54.consmr.mail.ir2.yahoo.com) (87.248.110.31) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Dec 2019 19:05:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1577819140; bh=jBiZ7nGo359Id+HhZ0WnKc9w1yg2SjFXPUTRayhQKWw=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=dzQed+20Bci0KVqKqQLfSNcYARZT/dtOLxScsYGcjdajKcCPPqbOei2Lfzd0RPlmTqduMWjtNmeryqKd4I5CQbJeCatvt55UgHP7qEIKrPloTSihUTYGwsiyiQPR7gIdMFTS3f3wLi7xCgqh/06ngfqRN3JvkxCImqraNJcEDEF14c5xAalj6q2P8ElyxkY4qu+L4V1MwFd0ne5vhLDRcK4InM1AN4yTVPNGuDMkAIn/u2cblOMdw4ZugdrRS+2ixpKjjdc040rbamavaJE6yUfhP6aoHk/DJ70KsM/CKjfdmL5it9EskQwXo7uHs5ZKBQpCt/p5ajeXCfcsS3LQcw== Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Tue, 31 Dec 2019 19:05:40 +0000 Date: Tue, 31 Dec 2019 19:05:00 -0000 From: "Hannes Domani via gdb-patches" Reply-To: Hannes Domani To: Gdb-patches Message-ID: <1134374112.8470290.1577819135686@mail.yahoo.com> In-Reply-To: <64c719e2-df88-6cd8-3f5b-246f0f7b7d58@simark.ca> References: <20191231184222.34267-1-ssbssa.ref@yahoo.de> <20191231184222.34267-1-ssbssa@yahoo.de> <64c719e2-df88-6cd8-3f5b-246f0f7b7d58@simark.ca> Subject: Re: [PATCH v2] Fix install-strip for cross-compilation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg01091.txt.bz2 Am Dienstag, 31. Dezember 2019, 19:50:47 MEZ hat Simon Marchi Folgendes geschrieben: > On 2019-12-31 1:42 p.m., Hannes Domani via gdb-patches wrote: > > > The variable INSTALL_PROGRAM_ENV sets up STRIPPROG for the cross-compil= er. > > > > If this is not done, the host 'strip' is used, and fails: > > > > /bin/sh /c/src/repos/binutils-gdb.git/install-sh -c -s gdb.exe \ > >=C2=A0 /gdb/gdb64-git/bin/$transformed_name.exe > > strip.exe:C:/gdb/gdb64-git/bin/_inst.33599_: file format not recognized > > > > With this change, it's fine: > > > > STRIPPROG=3D'x86_64-w64-mingw32-strip' \ > >=C2=A0 /bin/sh /c/src/repos/binutils-gdb.git/install-sh -c -s gdb.exe \ > >=C2=A0 /gdb/gdb64-git/bin/$transformed_name.exe > > > Thanks for updating the change log, this LGTM.=C2=A0 I believe you don't = have write access > to the repo, is that right?=C2=A0 Would you like me to push the patch on = your behalf, or > would you like to get a write access (useful if you plan on sending patch= es regularly)? Yes, I don't have write access, and I do plan to send more patches in the f= uture. With write access, is there more to it than just push the patch? Regards Hannes Domani