From: Simon Marchi <simark@simark.ca>
To: Jon Turney <jon.turney@dronecode.org.uk>, gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] Add handling for 64-bit module addresses in Cygwin core dumps
Date: Mon, 24 Aug 2020 14:34:10 -0400 [thread overview]
Message-ID: <60e372e8-647e-5e4d-1613-ca26b375e37e@simark.ca> (raw)
In-Reply-To: <20200812191816.23246-5-jon.turney@dronecode.org.uk>
On 2020-08-12 3:18 p.m., Jon Turney wrote:
> gdb/ChangeLog:
>
> 2020-07-01 Jon Turney <jon.turney@dronecode.org.uk>
>
> * windows-tdep.c (NOTE_INFO_MODULE, NOTE_INFO_MODULE64): Define.
> (core_process_module_section): Handle NOTE_INFO_MODULE64.
Hi Jon,
The series LGTM. It would be nice however if you could write some commit message
for this patch here, explaining what you are adding support for.
Simon
next prev parent reply other threads:[~2020-08-24 18:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 19:18 [PATCH 0/4] Add gdb support for Cygwin x86_64 core dumps (v2) Jon Turney
2020-08-12 19:18 ` [PATCH 1/4] Add sniffer for Cygwin x86_64 core dumps Jon Turney
2020-08-20 22:20 ` Simon Marchi
2020-08-21 15:25 ` Jon Turney
2020-08-21 16:22 ` Simon Marchi
2020-08-21 16:28 ` Jon Turney
2020-08-22 19:41 ` Simon Marchi
2020-08-22 19:52 ` Jon Turney
2020-08-24 15:47 ` Simon Marchi
2020-08-24 17:02 ` Jon Turney
2020-08-12 19:18 ` [PATCH 2/4] Add amd64_windows_gregset_reg_offset Jon Turney
2020-08-20 22:08 ` Simon Marchi
2020-09-18 16:31 ` Jon Turney
2020-08-12 19:18 ` [PATCH 3/4] Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str Jon Turney
2020-08-12 19:18 ` [PATCH 4/4] Add handling for 64-bit module addresses in Cygwin core dumps Jon Turney
2020-08-24 18:34 ` Simon Marchi [this message]
2020-09-15 21:44 ` Jon Turney
2020-09-16 2:20 ` Simon Marchi
2020-09-16 9:15 ` Christian Biesinger
2020-08-12 19:30 ` [PATCH 0/4] Add gdb support for Cygwin x86_64 core dumps (v2) Eli Zaretskii
2020-08-13 14:43 ` Jon Turney
2020-08-13 16:48 ` Eli Zaretskii
2020-08-18 15:32 ` Jon Turney
2020-08-18 16:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e372e8-647e-5e4d-1613-ca26b375e37e@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jon.turney@dronecode.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox