From: Jon Turney <jon.turney@dronecode.org.uk>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Add amd64_windows_gregset_reg_offset
Date: Fri, 18 Sep 2020 17:31:52 +0100 [thread overview]
Message-ID: <73d73956-a03d-1f75-bdfc-c3dc785194f7@dronecode.org.uk> (raw)
In-Reply-To: <a533a44a-76b6-bd40-5b7b-23f75bfd774e@simark.ca>
On 20/08/2020 23:08, Simon Marchi wrote:
> On 2020-08-12 3:18 p.m., Jon Turney wrote:
>> Register a gregset_reg_offset array for Cygwin x86_64 core dump parsing
>> (this causes the generic i386_iterate_over_regset_sections() '.reg'
>> section iterator to get installed by i386_gdbarch_init()).
One thing I notice is that, after this change, we now have (for both x86
and x86_64), a mapping between regno and CONTEXT offset both as a
gregset_reg_offset mapping (used when interpreting coredumps) and a
similar mapping fed into windows_set_context_register_offsets() (used on
an inferior process).
There's probably some scope for de-duplication and genericization there.
>> gdb/ChangeLog:
>>
>> 2020-07-01 Jon Turney <jon.turney@dronecode.org.uk>
>>
>> * amd64-windows-tdep.c(amd64_windows_gregset_reg_offset): Add.
>> (amd64_windows_init_abi_common): ... and register.
>
> That looks reasonable. I think i386_iterate_over_regset_sections should
> be made static, if you want to make another (obvious I would say) patch.
next prev parent reply other threads:[~2020-09-18 16:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 19:18 [PATCH 0/4] Add gdb support for Cygwin x86_64 core dumps (v2) Jon Turney
2020-08-12 19:18 ` [PATCH 1/4] Add sniffer for Cygwin x86_64 core dumps Jon Turney
2020-08-20 22:20 ` Simon Marchi
2020-08-21 15:25 ` Jon Turney
2020-08-21 16:22 ` Simon Marchi
2020-08-21 16:28 ` Jon Turney
2020-08-22 19:41 ` Simon Marchi
2020-08-22 19:52 ` Jon Turney
2020-08-24 15:47 ` Simon Marchi
2020-08-24 17:02 ` Jon Turney
2020-08-12 19:18 ` [PATCH 2/4] Add amd64_windows_gregset_reg_offset Jon Turney
2020-08-20 22:08 ` Simon Marchi
2020-09-18 16:31 ` Jon Turney [this message]
2020-08-12 19:18 ` [PATCH 3/4] Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str Jon Turney
2020-08-12 19:18 ` [PATCH 4/4] Add handling for 64-bit module addresses in Cygwin core dumps Jon Turney
2020-08-24 18:34 ` Simon Marchi
2020-09-15 21:44 ` Jon Turney
2020-09-16 2:20 ` Simon Marchi
2020-09-16 9:15 ` Christian Biesinger
2020-08-12 19:30 ` [PATCH 0/4] Add gdb support for Cygwin x86_64 core dumps (v2) Eli Zaretskii
2020-08-13 14:43 ` Jon Turney
2020-08-13 16:48 ` Eli Zaretskii
2020-08-18 15:32 ` Jon Turney
2020-08-18 16:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73d73956-a03d-1f75-bdfc-c3dc785194f7@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox