From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 49FF2386F036
 for <gdb-patches@sourceware.org>; Mon, 24 Aug 2020 18:34:11 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 49FF2386F036
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id E81DE1E009;
 Mon, 24 Aug 2020 14:34:10 -0400 (EDT)
Subject: Re: [PATCH 4/4] Add handling for 64-bit module addresses in Cygwin
 core dumps
To: Jon Turney <jon.turney@dronecode.org.uk>, gdb-patches@sourceware.org
References: <20200812191816.23246-1-jon.turney@dronecode.org.uk>
 <20200812191816.23246-5-jon.turney@dronecode.org.uk>
From: Simon Marchi <simark@simark.ca>
Message-ID: <60e372e8-647e-5e4d-1613-ca26b375e37e@simark.ca>
Date: Mon, 24 Aug 2020 14:34:10 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200812191816.23246-5-jon.turney@dronecode.org.uk>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Aug 2020 18:34:12 -0000

On 2020-08-12 3:18 p.m., Jon Turney wrote:
> gdb/ChangeLog:
> 
> 2020-07-01  Jon Turney  <jon.turney@dronecode.org.uk>
> 
> 	* windows-tdep.c (NOTE_INFO_MODULE, NOTE_INFO_MODULE64): Define.
> 	(core_process_module_section): Handle NOTE_INFO_MODULE64.

Hi Jon,

The series LGTM.  It would be nice however if you could write some commit message
for this patch here, explaining what you are adding support for.

Simon