Re: [pushed] gdb: fix typos in configure

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-11-27 15:35, Tom de Vries wrote:
> On 11/27/21 8:34 PM, Simon Marchi via Gdb-patches wrote:
>> The variable names used to restore CFLAGS and LDFLAGS here don't quite
>> match the names used above, resulting in losing the original CFLAGS and
>> LDFLAGS.  Fix that.
>>
> 
> Hi Simon,
> 
> thanks for fixing this mistake in my patch.
> 
> Trying to understand what I could have done to catch his, I tried
> shellcheck:
> ...
> $ shellcheck src/gdb/configure 2>&1 | grep -i save
>       save_CFLAGS=$CFLAGS
>       ^---------^ SC2034: save_CFLAGS appears unused. Verify use (or
> export if used externally).
>       save_LDFLAGS=$LDFLAGS
>       ^----------^ SC2034: save_LDFLAGS appears unused. Verify use (or
> export if used externally).
>       CFLAGS="$SAVE_CFLAGS"
>               ^----------^ SC2153: Possible misspelling: SAVE_CFLAGS may
> not be assigned, but save_CFLAGS is.
> ...
> and indeed the problem was found.
> 
> I'll try to use that next time I'll do a configure update.
> 
> Thanks,
> - Tom

I think shellcheck is great, but it's not so easy to use it on a
generated file that produces a ton of warnings already.

Simon