From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: [pushed] gdb: fix typos in configure
Date: Sat, 27 Nov 2021 14:34:20 -0500 [thread overview]
Message-ID: <20211127193420.722886-1-simon.marchi@polymtl.ca> (raw)
The variable names used to restore CFLAGS and LDFLAGS here don't quite
match the names used above, resulting in losing the original CFLAGS and
LDFLAGS. Fix that.
Change-Id: I9cc2c3b48b1dc30c31a7143563c893fd6f426a0a
---
gdb/configure | 8 ++++----
gdb/configure.ac | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/gdb/configure b/gdb/configure
index 90c1e3d7948b..448167f3c6d9 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -12138,8 +12138,8 @@ ac_compile='$CXX -c $CXXFLAGS $CPPFLAGS conftest.$ac_ext >&5'
ac_link='$CXX -o conftest$ac_exeext $CXXFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext $LIBS >&5'
ac_compiler_gnu=$ac_cv_cxx_compiler_gnu
- save_CFLAGS=$CFLAGS
- save_LDFLAGS=$LDFLAGS
+ save_CFLAGS="$CFLAGS"
+ save_LDFLAGS="$LDFLAGS"
CFLAGS="$CFLAGS $srchigh_pkg_cflags"
LDFLAGS="$LDFLAGS $srchigh_pkg_libs"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
@@ -12163,8 +12163,8 @@ else
fi
rm -f core conftest.err conftest.$ac_objext \
conftest$ac_exeext conftest.$ac_ext
- CFLAGS="$SAVE_CFLAGS"
- LDFLAGS="$SAVE_LDFLAGS"
+ CFLAGS="$save_CFLAGS"
+ LDFLAGS="$save_LDFLAGS"
ac_ext=c
ac_cpp='$CPP $CPPFLAGS'
ac_compile='$CC -c $CFLAGS $CPPFLAGS conftest.$ac_ext >&5'
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 29c1c4589c95..ada937316d73 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1265,8 +1265,8 @@ either use --disable-source-highlight or dnl
# This situation can occur for instance when using a source highlight
# library compiled with g++ 7.5.0 while building gdb with g++ 4.8.5.
AC_LANG_PUSH(C++)
- save_CFLAGS=$CFLAGS
- save_LDFLAGS=$LDFLAGS
+ save_CFLAGS="$CFLAGS"
+ save_LDFLAGS="$LDFLAGS"
CFLAGS="$CFLAGS $srchigh_pkg_cflags"
LDFLAGS="$LDFLAGS $srchigh_pkg_libs"
AC_LINK_IFELSE(
@@ -1278,8 +1278,8 @@ either use --disable-source-highlight or dnl
[have_usable_source_highlight=yes],
[have_usable_source_highlight=no]
)
- CFLAGS="$SAVE_CFLAGS"
- LDFLAGS="$SAVE_LDFLAGS"
+ CFLAGS="$save_CFLAGS"
+ LDFLAGS="$save_LDFLAGS"
AC_LANG_POP(C++)
if test "${have_usable_source_highlight}" = "yes"; then
--
2.33.1
next reply other threads:[~2021-11-27 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-27 19:34 Simon Marchi via Gdb-patches [this message]
2021-11-27 20:35 ` Tom de Vries via Gdb-patches
2021-11-28 0:35 ` Simon Marchi via Gdb-patches
2021-11-27 23:03 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211127193420.722886-1-simon.marchi@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox