From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tVPjHO3OomHDdAAAWB0awg (envelope-from ) for ; Sat, 27 Nov 2021 19:35:57 -0500 Received: by simark.ca (Postfix, from userid 112) id 5EF5B1F0CE; Sat, 27 Nov 2021 19:35:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ADFAC1ECEB for ; Sat, 27 Nov 2021 19:35:56 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B5A2A3857820 for ; Sun, 28 Nov 2021 00:35:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B5A2A3857820 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1638059755; bh=7lR1Z8Cue1BuQehhFMPAndcREzl3JM0wl4SIVmz3ayE=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=RHagr6lly8uL8KZp23VkqRUFSqh46PPWJsiZm1yFNIaHDJSgEExCoTPl4KfqsEI3C kjIfDRiHm1wXKctX16sdKpCSszPkcHGr329qKKbXrCB0T9qoYbimL9itXc/YQSzhkr t+mww2MPN2nbSPKp6t/NFt1+U6Pn+HHGZYFDX7m8= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 30F2A385840F for ; Sun, 28 Nov 2021 00:35:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 30F2A385840F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1AS0ZULJ024489 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 27 Nov 2021 19:35:35 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1AS0ZULJ024489 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 75E1A1ECEB; Sat, 27 Nov 2021 19:35:30 -0500 (EST) Message-ID: <606909fd-f3fe-4f42-790e-d36a0ec3124f@polymtl.ca> Date: Sat, 27 Nov 2021 19:35:30 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [pushed] gdb: fix typos in configure Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20211127193420.722886-1-simon.marchi@polymtl.ca> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 28 Nov 2021 00:35:30 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-11-27 15:35, Tom de Vries wrote: > On 11/27/21 8:34 PM, Simon Marchi via Gdb-patches wrote: >> The variable names used to restore CFLAGS and LDFLAGS here don't quite >> match the names used above, resulting in losing the original CFLAGS and >> LDFLAGS. Fix that. >> > > Hi Simon, > > thanks for fixing this mistake in my patch. > > Trying to understand what I could have done to catch his, I tried > shellcheck: > ... > $ shellcheck src/gdb/configure 2>&1 | grep -i save > save_CFLAGS=$CFLAGS > ^---------^ SC2034: save_CFLAGS appears unused. Verify use (or > export if used externally). > save_LDFLAGS=$LDFLAGS > ^----------^ SC2034: save_LDFLAGS appears unused. Verify use (or > export if used externally). > CFLAGS="$SAVE_CFLAGS" > ^----------^ SC2153: Possible misspelling: SAVE_CFLAGS may > not be assigned, but save_CFLAGS is. > ... > and indeed the problem was found. > > I'll try to use that next time I'll do a configure update. > > Thanks, > - Tom I think shellcheck is great, but it's not so easy to use it on a generated file that produces a ton of warnings already. Simon