Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: jtc@redback.com (J.T. Conklin)
To: Fernando Nasser <fnasser@cygnus.com>
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: [RFA]: Remove unused header files.
Date: Tue, 06 Mar 2001 11:32:00 -0000	[thread overview]
Message-ID: <5mwva266dz.fsf@jtc.redback.com> (raw)
In-Reply-To: <3AA51C5C.11099F0@cygnus.com>

>>>>> "Fernando" == Fernando Nasser <fnasser@cygnus.com> writes:
>> > The decode_line_1() declaration (IMO) indicates a unclear separation
>> > of interface and implementation.  (Again, IMO) a function declaration
>> > should only be in one header.  Please share your thoughts, on this
>> > specific case, and in general.  decode_line_1() is the first of many
>> > functions that have multiple declarations.


Fernando> I guess it should not be in symtab.c (old place), only in
Fernando> linespec.h (new place).  It may have been an oversight of my
Fernando> part.

No biggie.  

Fernando> Do you see any compilation failures if you remove the
Fernando> declaration of decode_line_1() from symtab.h?

Now that I know where the declaration is supposed to live, I'll try it
out.

        --jtc

-- 
J.T. Conklin
RedBack Networks


  reply	other threads:[~2001-03-06 11:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-01 17:44 J.T. Conklin
2001-03-02  8:25 ` Andrew Cagney
2001-03-02 16:34   ` J.T. Conklin
2001-03-05  8:11     ` Andrew Cagney
2001-03-06 13:08       ` J.T. Conklin
2001-03-05  8:11 ` Andrew Cagney
2001-03-06 13:10   ` J.T. Conklin
2001-03-05  8:11 ` Andrew Cagney
2001-03-06  9:20   ` Fernando Nasser
2001-03-06 11:32     ` J.T. Conklin [this message]
2001-03-06 13:27   ` J.T. Conklin
2001-03-06 15:06     ` Andrew Cagney
2001-03-05  8:11 ` Andrew Cagney
2001-03-06 12:41   ` J.T. Conklin
2001-03-05  8:11 ` Andrew Cagney
2001-03-06 12:38   ` J.T. Conklin
2001-03-05  8:11 ` Andrew Cagney
2001-03-06 13:02   ` J.T. Conklin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5mwva266dz.fsf@jtc.redback.com \
    --to=jtc@redback.com \
    --cc=fnasser@cygnus.com \
    --cc=gdb-patches@sourceware.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox