Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: jtc@redback.com
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: [RFA]: Remove unused header files.
Date: Mon, 05 Mar 2001 08:11:00 -0000	[thread overview]
Message-ID: <3AA2C971.D2432CEA@cygnus.com> (raw)
In-Reply-To: <5mitltndwn.fsf@jtc.redback.com>

> The decode_line_1() declaration (IMO) indicates a unclear separation
> of interface and implementation.  (Again, IMO) a function declaration
> should only be in one header.  Please share your thoughts, on this
> specific case, and in general.  decode_line_1() is the first of many
> functions that have multiple declarations.

Only one? Just don't get me started on the number of extern declarations
that appear in .c files! :-)  Yes, I agree that function declarations
should only appear once.

As for the more general question of confused interfaces.  I think GDB's
internal structure is facing major change (multi-arch).  Consequently
I'm hopeing that that that that work will address many of those
problems.  I suspect that, at this stage, you might want to put blinkers
and just concentrate on the basic #include mess.  That, by its self, is
pretty daunting.

Good luck!
	Andrew


  parent reply	other threads:[~2001-03-05  8:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-01 17:44 J.T. Conklin
2001-03-02  8:25 ` Andrew Cagney
2001-03-02 16:34   ` J.T. Conklin
2001-03-05  8:11     ` Andrew Cagney
2001-03-06 13:08       ` J.T. Conklin
2001-03-05  8:11 ` Andrew Cagney
2001-03-06 12:38   ` J.T. Conklin
2001-03-05  8:11 ` Andrew Cagney
2001-03-06 13:02   ` J.T. Conklin
2001-03-05  8:11 ` Andrew Cagney [this message]
2001-03-06  9:20   ` Fernando Nasser
2001-03-06 11:32     ` J.T. Conklin
2001-03-06 13:27   ` J.T. Conklin
2001-03-06 15:06     ` Andrew Cagney
2001-03-05  8:11 ` Andrew Cagney
2001-03-06 12:41   ` J.T. Conklin
2001-03-05  8:11 ` Andrew Cagney
2001-03-06 13:10   ` J.T. Conklin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AA2C971.D2432CEA@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sourceware.cygnus.com \
    --cc=jtc@redback.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox