From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: jtc@redback.com Cc: gdb-patches@sourceware.cygnus.com Subject: Re: [RFA]: Remove unused header files. Date: Mon, 05 Mar 2001 08:11:00 -0000 Message-id: <3AA2C971.D2432CEA@cygnus.com> References: <5mitltndwn.fsf@jtc.redback.com> X-SW-Source: 2001-03/msg00067.html > The decode_line_1() declaration (IMO) indicates a unclear separation > of interface and implementation. (Again, IMO) a function declaration > should only be in one header. Please share your thoughts, on this > specific case, and in general. decode_line_1() is the first of many > functions that have multiple declarations. Only one? Just don't get me started on the number of extern declarations that appear in .c files! :-) Yes, I agree that function declarations should only appear once. As for the more general question of confused interfaces. I think GDB's internal structure is facing major change (multi-arch). Consequently I'm hopeing that that that that work will address many of those problems. I suspect that, at this stage, you might want to put blinkers and just concentrate on the basic #include mess. That, by its self, is pretty daunting. Good luck! Andrew