From mboxrd@z Thu Jan 1 00:00:00 1970 From: jtc@redback.com (J.T. Conklin) To: Fernando Nasser Cc: gdb-patches@sourceware.cygnus.com Subject: Re: [RFA]: Remove unused header files. Date: Tue, 06 Mar 2001 11:32:00 -0000 Message-id: <5mwva266dz.fsf@jtc.redback.com> References: <5mitltndwn.fsf@jtc.redback.com> <3AA2C971.D2432CEA@cygnus.com> <3AA51C5C.11099F0@cygnus.com> X-SW-Source: 2001-03/msg00117.html >>>>> "Fernando" == Fernando Nasser writes: >> > The decode_line_1() declaration (IMO) indicates a unclear separation >> > of interface and implementation. (Again, IMO) a function declaration >> > should only be in one header. Please share your thoughts, on this >> > specific case, and in general. decode_line_1() is the first of many >> > functions that have multiple declarations. Fernando> I guess it should not be in symtab.c (old place), only in Fernando> linespec.h (new place). It may have been an oversight of my Fernando> part. No biggie. Fernando> Do you see any compilation failures if you remove the Fernando> declaration of decode_line_1() from symtab.h? Now that I know where the declaration is supposed to live, I'll try it out. --jtc -- J.T. Conklin RedBack Networks