Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: [PATCH, gdb/testsuite] Fix calls in gdb.arch/thumb2-it.exp
Date: Wed, 06 Sep 2017 15:26:00 -0000	[thread overview]
Message-ID: <58a6af50-7bd9-f6c7-dbed-98c473e5e07d@foss.arm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Hi,

Tests in gdb.arch/thumb2-it.exp call functions defined in assembly
without type debugging information. Since
7022349d5c86bae74b49225515f42d2e221bd368 this triggers an error which
leads to many tests to FAIL. This patch cast the call to indicate the
return type of the functions when calling them.

ChangeLog entry is as follows:

*** gdb/testsuite/ChangeLog ***

2017-09-06  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	* gdb.arch/thumb2-it.exp: Cast call to assembly defined function.

All tests in that exp file PASS after that change.

Is this ok for master?

Best regards,

Thomas

[-- Attachment #2: fix_thumb2-it_exp.patch --]
[-- Type: text/x-patch, Size: 795 bytes --]

diff --git a/gdb/testsuite/gdb.arch/thumb2-it.exp b/gdb/testsuite/gdb.arch/thumb2-it.exp
index ab0dae38e302cdfef0232780612ea9a2f36d7f54..e100d068b3a92f24fb1bd0f8ffaedcc58d7512a8 100644
--- a/gdb/testsuite/gdb.arch/thumb2-it.exp
+++ b/gdb/testsuite/gdb.arch/thumb2-it.exp
@@ -58,7 +58,7 @@ proc test_it_block { func } {
 	return
     }
 
-    gdb_test "call ${func}()" "Breakpoint.*@ Setup.*" "$func, call"
+    gdb_test "call (int) ${func}()" "Breakpoint.*@ Setup.*" "$func, call"
 
     set expected 0
     set reached 0
@@ -155,7 +155,7 @@ for { set i 1 } { $i <= 8 } { incr i } {
 }
 
 gdb_breakpoint "*it_breakpoints"
-gdb_test "call it_breakpoints()" "Breakpoint.*"
+gdb_test "call (int) it_breakpoints()" "Breakpoint.*"
 for { set i 1 } { $i <= 7 } { incr i } {
     test_it_break ${i}
 }

             reply	other threads:[~2017-09-06 15:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06 15:26 Thomas Preudhomme [this message]
2017-09-06 15:32 ` Pedro Alves
2017-09-06 16:56   ` Thomas Preudhomme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58a6af50-7bd9-f6c7-dbed-98c473e5e07d@foss.arm.com \
    --to=thomas.preudhomme@foss.arm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox