Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: Pedro Alves <palves@redhat.com>,
	GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH, gdb/testsuite] Fix calls in gdb.arch/thumb2-it.exp
Date: Wed, 06 Sep 2017 16:56:00 -0000	[thread overview]
Message-ID: <404c536f-9706-d3b8-1468-412482b2d6fd@foss.arm.com> (raw)
In-Reply-To: <69663edc-817b-17c3-7ce5-930f1bf0e949@redhat.com>



On 06/09/17 16:31, Pedro Alves wrote:
> On 09/06/2017 04:26 PM, Thomas Preudhomme wrote:
>> Hi,
>>
>> Tests in gdb.arch/thumb2-it.exp call functions defined in assembly
>> without type debugging information. Since
>> 7022349d5c86bae74b49225515f42d2e221bd368
> 
> I find Linux's style to refer to past commits helpful when
> reading commit logs.  I.e., also mention the commit subject, like:
> 
> ... Since 7022349d5c86 ("Stop assuming no-debug-info functions
> return int"), this triggers ...
> 
> This gives a clue to humans what the commit is about.

Indeed, thanks for the suggestion.

> 
>> this triggers an error which
>> leads to many tests to FAIL. This patch cast the call to indicate the
>> return type of the functions when calling them.
> 
>>
>> Is this ok for master?
> 
> OK.

Pushed.

Best regards,

Thomas


      reply	other threads:[~2017-09-06 16:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06 15:26 Thomas Preudhomme
2017-09-06 15:32 ` Pedro Alves
2017-09-06 16:56   ` Thomas Preudhomme [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=404c536f-9706-d3b8-1468-412482b2d6fd@foss.arm.com \
    --to=thomas.preudhomme@foss.arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox