From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100333 invoked by alias); 6 Sep 2017 16:56:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100289 invoked by uid 89); 6 Sep 2017 16:56:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=humans X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Sep 2017 16:56:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E0D4C80D; Wed, 6 Sep 2017 09:56:26 -0700 (PDT) Received: from [10.2.206.52] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6784A3F540; Wed, 6 Sep 2017 09:56:26 -0700 (PDT) Subject: Re: [PATCH, gdb/testsuite] Fix calls in gdb.arch/thumb2-it.exp To: Pedro Alves , GDB Patches References: <58a6af50-7bd9-f6c7-dbed-98c473e5e07d@foss.arm.com> <69663edc-817b-17c3-7ce5-930f1bf0e949@redhat.com> From: Thomas Preudhomme Message-ID: <404c536f-9706-d3b8-1468-412482b2d6fd@foss.arm.com> Date: Wed, 06 Sep 2017 16:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <69663edc-817b-17c3-7ce5-930f1bf0e949@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00155.txt.bz2 On 06/09/17 16:31, Pedro Alves wrote: > On 09/06/2017 04:26 PM, Thomas Preudhomme wrote: >> Hi, >> >> Tests in gdb.arch/thumb2-it.exp call functions defined in assembly >> without type debugging information. Since >> 7022349d5c86bae74b49225515f42d2e221bd368 > > I find Linux's style to refer to past commits helpful when > reading commit logs. I.e., also mention the commit subject, like: > > ... Since 7022349d5c86 ("Stop assuming no-debug-info functions > return int"), this triggers ... > > This gives a clue to humans what the commit is about. Indeed, thanks for the suggestion. > >> this triggers an error which >> leads to many tests to FAIL. This patch cast the call to indicate the >> return type of the functions when calling them. > >> >> Is this ok for master? > > OK. Pushed. Best regards, Thomas